From: Gerd Knorr <kraxel@suse.de>
To: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Cc: Jean Delvare <khali@linux-fr.org>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
video4linux-list@redhat.com
Subject: Re: [PATCH] Adds support for TEA5767 chipset on V4L
Date: 14 Jun 2005 09:29:42 +0200 [thread overview]
Message-ID: <8764wh2y6x.fsf@bytesex.org> (raw)
In-Reply-To: <42ADD33F.3020100@brturbo.com.br>
Mauro Carvalho Chehab <mchehab@brturbo.com.br> writes:
> >>+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
> >>+#include "tuner.h"
> >>+#include "i2c-compat.h"
> >>+#else
> >>+#include <media/tuner.h>
> >>+#endif
> >No such test please, it is useless. This is Linux 2.6.x, no need to
> >check this.
> There's a script to eliminate this before submiting the patch... For
> some reason, as you pointed, it had failed for this code... I'll review
> it next time.
btw: is anyone testing the v4l cvs on 2.4 kernels? I stopped doing
that quite a while ago, alot of stuff (dvb support) doesn't build on
2.4 kernels anyway, so its probably reasonable to cleanup the code in
cvs as well and simply drop the 2.4 code ...
Gerd
--
-mm seems unusually stable at present.
-- akpm about 2.6.12-rc3-mm3
prev parent reply other threads:[~2005-06-14 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-12 21:33 [PATCH] Adds support for TEA5767 chipset on V4L Mauro Carvalho Chehab
2005-06-13 16:35 ` Jean Delvare
2005-06-13 18:41 ` Mauro Carvalho Chehab
2005-06-14 7:29 ` Gerd Knorr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8764wh2y6x.fsf@bytesex.org \
--to=kraxel@suse.de \
--cc=akpm@osdl.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox