Re: Linux 2.4.25-rc4

Pavel Machek
2004-02-20T22:51:26Z

Hi!

> > On Wed, Feb 18, 2004 at 02:11:24AM -0300, Marcelo Tosatti wrote:
> > > Here goes release candidate 4, including a few small fixes.
> > >
> > > If nothing bad shows up, this will become final.
> >
> > Well, I would have liked to see the ACPI poweroff fix I sent a few days ago,
> > but Len said he doesn't have time to review it this week. It's a shame since
> > at least two of my machines which powered off correctly with very older ACPI
> > versions now need it, so I don't think I'm the only one in this case :-(
> >
> > Other than that, I'm fairly happy with at least -rc2 (not tested latest
> > releases yet).
>
> Hi Willy,
>
> Your fix looks ok. I dont think calling acpi_system_save_state(S5) can
> cause any breakage. Len?

I bet it will create "machine will reboot instead of poweroff" on some
strange machine.... Perhaps it fixes more machines than it breaks, but
it will probably break some.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]