Re: Linux 2.4.25-rc4

Pavel Machek
2004-02-22T22:03:21Z

Hi!

> > > Your fix looks ok. I dont think calling acpi_system_save_state(S5) can
> > > cause any breakage. Len?
> >
> > I bet it will create "machine will reboot instead of poweroff" on some
> > strange machine.... Perhaps it fixes more machines than it breaks, but
> > it will probably break some.
>
> This is interesting. Do you have an idea about what could break
> exactly ?

No, but this is ACPI. No matter how simple change looks, it will break
something.

> In my case, I have noticed two things :
> - if I disable local APIC, the standard code works
> - if I enable local APIC, I need the patch above.
>
> So perhaps it would be enough to disable local APIC instead of calling this
> function ?

Hmm.. that means we need APIC driver model...
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]