From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Zwane Mwaikambo <zwane@linux.realnet.co.sz>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, <sct@redhat.com>
Subject: Re: [PATCH] if (foo) kfree(foo) /fs cleanup + reverted JBD code path changes
Date: Sun, 02 Dec 2001 02:14:15 +0900 [thread overview]
Message-ID: <87667qrhg8.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <Pine.LNX.4.33.0112011830550.14290-100000@netfinity.realnet.co.sz>
In-Reply-To: <Pine.LNX.4.33.0112011830550.14290-100000@netfinity.realnet.co.sz>
Zwane Mwaikambo <zwane@linux.realnet.co.sz> writes:
> out_fail:
> - if (opts.iocharset) {
> - printk("FAT: freeing iocharset=%s\n", opts.iocharset);
> - kfree(opts.iocharset);
> - }
> - if(sbi->private_data)
> - kfree(sbi->private_data);
> + printk("FAT: freeing iocharset=%s\n", opts.iocharset);
In all failed cases, this message will be outputted. I think I shouldn't do
so. (or remove this message.)
> + kfree(opts.iocharset);
> +
> + kfree(sbi->private_data);
> sbi->private_data = NULL;
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2001-12-01 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-01 11:36 [PATCH] if (foo) kfree(foo) /fs cleanup Zwane Mwaikambo
2001-12-01 12:45 ` Alan Cox
2001-12-01 12:49 ` Jeff Garzik
2001-12-01 13:10 ` Zwane Mwaikambo
2001-12-01 16:33 ` [PATCH] if (foo) kfree(foo) /fs cleanup + reverted JBD code path changes Zwane Mwaikambo
2001-12-01 17:14 ` OGAWA Hirofumi [this message]
2001-12-01 17:48 ` Zwane Mwaikambo
2001-12-01 18:05 ` OGAWA Hirofumi
2001-12-01 18:13 ` Zwane Mwaikambo
[not found] ` <Pine.LNX.4.33.0112011830550.14290-100000@netfinity.realnet.co.s z>
2001-12-01 17:40 ` Alex Bligh - linux-kernel
2001-12-01 18:02 ` Zwane Mwaikambo
2001-12-01 18:11 ` Zwane Mwaikambo
2001-12-01 20:40 ` Raja R Harinath
2001-12-01 21:25 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87667qrhg8.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=zwane@linux.realnet.co.sz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox