From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Frank Li" <Frank.Li@nxp.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Zhiqiang.Hou@nxp.com
Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 2/4] dt-bindings: PCI: drop layerscape-pcie-gen4.txt
Date: Sat, 10 Aug 2024 17:00:48 +0200 [thread overview]
Message-ID: <876d79d3-acf7-442e-b7fb-89df00a5fd18@kernel.org> (raw)
In-Reply-To: <20240808-mobivel_cleanup-v1-2-f4f6ea5b16de@nxp.com>
On 08/08/2024 18:02, Frank Li wrote:
> lx2160 rev1 use mobivel PCIe controller and switch to designware PCIe
> controller at rev2, which is mass production version. So drop unused
> document.
Compatible is still used. Also, wrong order of patches. Dropping
bindings is THE LAST patch.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../bindings/pci/layerscape-pcie-gen4.txt | 52 ----------------------
> 1 file changed, 52 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/layerscape-pcie-gen4.txt b/Documentation/devicetree/bindings/pci/layerscape-pcie-gen4.txt
> deleted file mode 100644
> index b40fb5d15d3d9..0000000000000
> --- a/Documentation/devicetree/bindings/pci/layerscape-pcie-gen4.txt
> +++ /dev/null
> @@ -1,52 +0,0 @@
> -NXP Layerscape PCIe Gen4 controller
> -
> -This PCIe controller is based on the Mobiveil PCIe IP and thus inherits all
> -the common properties defined in mobiveil-pcie.txt.
So this explains all the confusion about your DTS patches, but this was
nowwhere explained! Nothing here mentions DTS users. Nothing in DTS
patch mentions dropping bindings with rationale.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-10 15:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 16:02 [PATCH 0/4] PCI: mobivel: Drop layerscape gen4 support Frank Li
2024-08-08 16:02 ` [PATCH 1/4] dt-bindings: PCI: layerscape-pci: drop compatible string fsl,lx2160a-pcie Frank Li
2024-08-10 14:58 ` Krzysztof Kozlowski
2024-08-08 16:02 ` [PATCH 2/4] dt-bindings: PCI: drop layerscape-pcie-gen4.txt Frank Li
2024-08-10 15:00 ` Krzysztof Kozlowski [this message]
2024-08-08 16:02 ` [PATCH 3/4] PCI: mobiveil: Drop layerscape-gen4 support Frank Li
2024-08-08 17:26 ` Bjorn Helgaas
2024-08-08 18:08 ` Frank Li
2024-08-10 15:01 ` Krzysztof Kozlowski
2024-08-08 16:02 ` [PATCH 4/4] MAINTAINERS: drop NXP LAYERSCAPE GEN4 CONTROLLER Frank Li
2024-08-10 14:54 ` Krzysztof Kozlowski
2024-08-15 15:53 ` Manivannan Sadhasivam
2024-08-15 21:15 ` Rob Herring
2024-08-16 5:42 ` Manivannan Sadhasivam
2024-08-16 17:09 ` Frank Li
2024-08-16 18:15 ` Bjorn Helgaas
2024-08-16 19:17 ` Frank Li
2024-08-16 23:14 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876d79d3-acf7-442e-b7fb-89df00a5fd18@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox