Re: [PATCH 3/4] regulator: Support the LTM8054 voltage regulator

Romain Gantois
2025-09-18T09:32:00Z

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On Tuesday, 16 September 2025 16:17:56 CEST Romain Gantois wrote:
> Hello Andy,
>
> On Tuesday, 16 September 2025 15:12:37 CEST Andy Shevchenko wrote:
> > On Tue, Sep 16, 2025 at 12:24:08PM +0200, Romain Gantois wrote:
> > > Add a stub driver for the Linear Technology LTM8054 Buck-Boost voltage
> > > regulator. This version only supports enabling/disabling the regulator
> > > via
> > > a GPIO, and reporting the output voltage level from the resistor divider
> > > values given in the device tree.
> >
> > ...
> >
> > > +#include <linux/module.h>
> > > +#include <linux/of.h>
> >
> > I think we have already something agnostic in regulator API to get a
> > regulator from a firmware node (rather than from specific OF/etc one).
>
> IIRC the "of_match" regulator descriptor property can be used for this, I'll
> have a second look and see if I can use that instead.
>

Looks like I misread your comment sorry, the "of_match" property is pretty
much irrelevant to using fwnode_* wrappers, and I didn't find any of those in
the regulator subsystem. I'm missing a Kconfig dependency on "OF" though, I'll
have to add that.

Thanks,

--
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]