Re: [PATCH 3/4] regulator: Support the LTM8054 voltage regulator

Andy Shevchenko
2025-09-18T19:18:06Z

On Thu, Sep 18, 2025 at 11:31:50AM +0200, Romain Gantois wrote:
> On Tuesday, 16 September 2025 16:17:56 CEST Romain Gantois wrote:
> > On Tuesday, 16 September 2025 15:12:37 CEST Andy Shevchenko wrote:
> > > On Tue, Sep 16, 2025 at 12:24:08PM +0200, Romain Gantois wrote:

...

> > > > +#include <linux/of.h>
> > >
> > > I think we have already something agnostic in regulator API to get a
> > > regulator from a firmware node (rather than from specific OF/etc one).
> >
> > IIRC the "of_match" regulator descriptor property can be used for this, I'll
> > have a second look and see if I can use that instead.
>
> Looks like I misread your comment sorry, the "of_match" property is pretty
> much irrelevant to using fwnode_* wrappers, and I didn't find any of those in
> the regulator subsystem. I'm missing a Kconfig dependency on "OF" though, I'll
> have to add that.

Why do we need to add that dependency? Yes, probably it won't function,
but then it will decrease test coverage at compile time.

--
With Best Regards,
Andy Shevchenko