From: Takashi Iwai <tiwai@suse.de>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] sound: pci: asihpi: use pcim_iomap for managed PCI memory mapping
Date: Tue, 11 Aug 2026 08:20:31 +0200 [thread overview]
Message-ID: <877blxb2kw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260811042122.44923-1-rosenp@gmail.com>
On Tue, 11 Aug 2026 06:21:22 +0200,
Rosen Penev wrote:
>
> Replace manual ioremap() calls with pcim_iomap() which uses devres
> for automatic cleanup. This eliminates the need for manual iounmap()
> in both the error path of asihpi_adapter_probe() and the
> asihpi_adapter_remove() function.
>
> The pcim_iomap() helper is cleaner and less error-prone since it
> handles unmapping automatically when the PCI device is released.
>
> Assisted-by: opencode/big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-08-11 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 4:21 [PATCH] sound: pci: asihpi: use pcim_iomap for managed PCI memory mapping Rosen Penev
2026-08-11 6:20 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877blxb2kw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rosenp@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox