From: Thomas Gleixner <tglx@kernel.org>
To: Melody Wang <huibo.wang@amd.com>, x86@kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, Melody Wang <huibo.wang@amd.com>
Subject: Re: [PATCH] x86/apic: Ensure ICR register write value is handled as 32 bits
Date: Mon, 20 Jul 2026 20:41:05 +0200 [thread overview]
Message-ID: <877bmpmrlq.ffs@fw13> (raw)
In-Reply-To: <20260708012117.177959-1-huibo.wang@amd.com>
On Wed, Jul 08 2026 at 01:21, Melody Wang wrote:
> The low 32-bit ICR data is prepared by __prepare_ICR(), which returns
> a 32-bit value. However, when this value is assigned to a new variable,
> it's easy to mistakenly declare that variable with a different width.
>
> To avoid this class of mistakes, use __prepare_ICR() directly as the
> function argument instead of storing its result in an intermediate
> variable. This also shaves off a bunch of lines in the code.
>
> There should be no functionality change resulting from this patch.
>
> Signed-off-by: Melody Wang <huibo.wang@amd.com>
Acked-by: Thomas Gleixner <tglx@kernel.org>
next prev parent reply other threads:[~2026-07-20 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 1:21 [PATCH] x86/apic: Ensure ICR register write value is handled as 32 bits Melody Wang
2026-07-20 18:41 ` Thomas Gleixner [this message]
2026-07-20 19:27 ` [tip: x86/cleanups] " tip-bot2 for Melody Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bmpmrlq.ffs@fw13 \
--to=tglx@kernel.org \
--cc=huibo.wang@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox