public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: opti9xx: restore snd-miro state after resume
Date: Tue, 14 Apr 2026 09:07:42 +0200	[thread overview]
Message-ID: <877bqat3y9.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260413-alsa-miro-pm-v1-1-07cc1ce3463c@gmail.com>

On Mon, 13 Apr 2026 21:45:34 +0200,
Cássio Gabriel wrote:
> 
> snd-miro has no PM callbacks, so system resume leaves the OPTi
> master-control registers and the board-specific ACI mixer state
> unrestored.
> 
> Like snd-opti9xx, the driver needs to reprogram the OPTi routing
> registers before bringing the codec back. snd-miro also keeps mixer
> state in the ACI block, so the codec resume callback alone is not
> enough here. Save the ACI mixer state on suspend, reinitialize the
> OPTi and ACI state on resume, replay the saved ACI values, and then
> resume the WSS codec. Hook the PM handlers into both the ISA and PnP
> paths.
> 
> Also initialize miro->card on the ISA path for the existing dev_*()
> logging and keep the cached solo-mode value aligned with the value
> written to hardware.
> 
> PCM20 radio tuner state remains outside this driver's PM scope.
> 
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>

As it's no trivial change and we are already in the merge window, I'd
postpone this for 7.2.  Or, if this is the very last piece of your
whole changes, I can try to put.  Let me know.


thanks,

Takashi

  reply	other threads:[~2026-04-14  7:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 19:45 [PATCH] ALSA: opti9xx: restore snd-miro state after resume Cássio Gabriel
2026-04-14  7:07 ` Takashi Iwai [this message]
2026-04-14 11:14   ` Cássio Gabriel Monteiro Pires
2026-04-14 11:51     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877bqat3y9.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=cassiogabrielcontato@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox