[PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Lei Huang]

From: Lei Huang <huanglei@kylinos.cn>

Fix checkpatch code style errors:

  ERROR: else should follow close brace '}'
  #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
  +       }
  +       else

Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
Signed-off-by: Lei Huang <huanglei@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 09af4d378b30..afe13a7f2673 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -2296,9 +2296,9 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,
 		struct alc_spec *spec = codec->spec;
 		spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
 		alc255_set_default_jack_type(codec);
-	}
-	else
+	} else {
 		alc_fixup_headset_mode(codec, fix, action);
+	}
 }
 
 static void alc288_update_headset_jack_cb(struct hda_codec *codec,
-- 
2.25.1

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Takashi Iwai]

On Tue, 31 Mar 2026 09:54:05 +0200,
Lei Huang wrote:
> 
> From: Lei Huang <huanglei@kylinos.cn>
> 
> Fix checkpatch code style errors:
> 
>   ERROR: else should follow close brace '}'
>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>   +       }
>   +       else
> 
> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
> Signed-off-by: Lei Huang <huanglei@kylinos.cn>

Thanks, applied to for-next branch.


Takashi

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Krzysztof Kozlowski]

On 31/03/2026 10:20, Takashi Iwai wrote:
> On Tue, 31 Mar 2026 09:54:05 +0200,
> Lei Huang wrote:
>>
>> From: Lei Huang <huanglei@kylinos.cn>
>>
>> Fix checkpatch code style errors:
>>
>>   ERROR: else should follow close brace '}'
>>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>>   +       }
>>   +       else
>>
>> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
>> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
> 
> Thanks, applied to for-next branch.

I hope you dropped the fake Fixes tag. Or at least give people chance to
review it.

Best regards,
Krzysztof

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Krzysztof Kozlowski]

On 01/04/2026 12:43, Krzysztof Kozlowski wrote:
> On 31/03/2026 10:20, Takashi Iwai wrote:
>> On Tue, 31 Mar 2026 09:54:05 +0200,
>> Lei Huang wrote:
>>>
>>> From: Lei Huang <huanglei@kylinos.cn>
>>>
>>> Fix checkpatch code style errors:
>>>
>>>   ERROR: else should follow close brace '}'
>>>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>>>   +       }
>>>   +       else
>>>
>>> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
>>> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
>>
>> Thanks, applied to for-next branch.
> 
> I hope you dropped the fake Fixes tag. Or at least give people chance to
> review it.

I see you entirely ignored all the comments about fake bug being fixed here.

Best regards,
Krzysztof

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Takashi Iwai]

On Fri, 10 Apr 2026 09:11:39 +0200,
Krzysztof Kozlowski wrote:
> 
> On 01/04/2026 12:43, Krzysztof Kozlowski wrote:
> > On 31/03/2026 10:20, Takashi Iwai wrote:
> >> On Tue, 31 Mar 2026 09:54:05 +0200,
> >> Lei Huang wrote:
> >>>
> >>> From: Lei Huang <huanglei@kylinos.cn>
> >>>
> >>> Fix checkpatch code style errors:
> >>>
> >>>   ERROR: else should follow close brace '}'
> >>>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
> >>>   +       }
> >>>   +       else
> >>>
> >>> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
> >>> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
> >>
> >> Thanks, applied to for-next branch.
> > 
> > I hope you dropped the fake Fixes tag. Or at least give people chance to
> > review it.
> 
> I see you entirely ignored all the comments about fake bug being fixed here.

I saw your comments, but I have a different opinion.
In the case of HD-audio code where the code change happens very
actively and quite often backported to stable trees, a change like
this would block the further backports if missing.  With a hint of
Fixes tag, the change of the code change can be tracked more easily,
hence it's still worth to have.


thanks,

Takashi

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Krzysztof Kozlowski]

On 10/04/2026 09:30, Takashi Iwai wrote:
> On Fri, 10 Apr 2026 09:11:39 +0200,
> Krzysztof Kozlowski wrote:
>>
>> On 01/04/2026 12:43, Krzysztof Kozlowski wrote:
>>> On 31/03/2026 10:20, Takashi Iwai wrote:
>>>> On Tue, 31 Mar 2026 09:54:05 +0200,
>>>> Lei Huang wrote:
>>>>>
>>>>> From: Lei Huang <huanglei@kylinos.cn>
>>>>>
>>>>> Fix checkpatch code style errors:
>>>>>
>>>>>   ERROR: else should follow close brace '}'
>>>>>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>>>>>   +       }
>>>>>   +       else
>>>>>
>>>>> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
>>>>> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
>>>>
>>>> Thanks, applied to for-next branch.
>>>
>>> I hope you dropped the fake Fixes tag. Or at least give people chance to
>>> review it.
>>
>> I see you entirely ignored all the comments about fake bug being fixed here.
> 
> I saw your comments, but I have a different opinion.
> In the case of HD-audio code where the code change happens very
> actively and quite often backported to stable trees, a change like
> this would block the further backports if missing.  With a hint of

No, it would not. Commits marked for backports can even mention
dependencies.

> Fixes tag, the change of the code change can be tracked more easily,
> hence it's still worth to have.

Fake fixes tag is not the solution for that. It adds effort on stable
team for no gain, it adds work on people evaluating backported commits
for no gain.

BTW, since I was looking at your tree - you have contributions from
songxiebing@kylinos.cn which does not follow requirements for a *known
identity*. IOW, it does not pass DCO requirements and should not be
accepted.

Best regards,
Krzysztof

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Takashi Iwai]

On Fri, 10 Apr 2026 09:41:33 +0200,
Krzysztof Kozlowski wrote:
> 
> On 10/04/2026 09:30, Takashi Iwai wrote:
> > On Fri, 10 Apr 2026 09:11:39 +0200,
> > Krzysztof Kozlowski wrote:
> >>
> >> On 01/04/2026 12:43, Krzysztof Kozlowski wrote:
> >>> On 31/03/2026 10:20, Takashi Iwai wrote:
> >>>> On Tue, 31 Mar 2026 09:54:05 +0200,
> >>>> Lei Huang wrote:
> >>>>>
> >>>>> From: Lei Huang <huanglei@kylinos.cn>
> >>>>>
> >>>>> Fix checkpatch code style errors:
> >>>>>
> >>>>>   ERROR: else should follow close brace '}'
> >>>>>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
> >>>>>   +       }
> >>>>>   +       else
> >>>>>
> >>>>> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
> >>>>> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
> >>>>
> >>>> Thanks, applied to for-next branch.
> >>>
> >>> I hope you dropped the fake Fixes tag. Or at least give people chance to
> >>> review it.
> >>
> >> I see you entirely ignored all the comments about fake bug being fixed here.
> > 
> > I saw your comments, but I have a different opinion.
> > In the case of HD-audio code where the code change happens very
> > actively and quite often backported to stable trees, a change like
> > this would block the further backports if missing.  With a hint of
> 
> No, it would not. Commits marked for backports can even mention
> dependencies.
> 
> > Fixes tag, the change of the code change can be tracked more easily,
> > hence it's still worth to have.
> 
> Fake fixes tag is not the solution for that. It adds effort on stable
> team for no gain, it adds work on people evaluating backported commits
> for no gain.

It actually helps a lot on distro side, judging from my long
experience of backporting (literally) million of patches for openSUSE
/ SUSE kernels.

> BTW, since I was looking at your tree - you have contributions from
> songxiebing@kylinos.cn which does not follow requirements for a *known
> identity*. IOW, it does not pass DCO requirements and should not be
> accepted.

Do you mean the form
  Signed-off-by: songxiebing <songxiebing@kylinos.cn>
?

The name spelling without space is pretty normal in Chinese.


thanks,

Takashi

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Krzysztof Kozlowski]

On 10/04/2026 09:46, Takashi Iwai wrote:
> 
> It actually helps a lot on distro side, judging from my long
> experience of backporting (literally) million of patches for openSUSE
> / SUSE kernels.
> 
>> BTW, since I was looking at your tree - you have contributions from
>> songxiebing@kylinos.cn which does not follow requirements for a *known
>> identity*. IOW, it does not pass DCO requirements and should not be
>> accepted.
> 
> Do you mean the form
>   Signed-off-by: songxiebing <songxiebing@kylinos.cn>
> ?
> 
> The name spelling without space is pretty normal in Chinese.

It is a copy of email username. I am no expert, but usually Latin
transliterations have differences from usernames (and Google confirms
that space is expected for transliteration, although Google is no expert
either), so this looks like semi-configured Git.

Best regards,
Krzysztof

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Takashi Iwai]

On Fri, 10 Apr 2026 10:03:12 +0200,
Krzysztof Kozlowski wrote:
> 
> On 10/04/2026 09:46, Takashi Iwai wrote:
> > 
> > It actually helps a lot on distro side, judging from my long
> > experience of backporting (literally) million of patches for openSUSE
> > / SUSE kernels.
> > 
> >> BTW, since I was looking at your tree - you have contributions from
> >> songxiebing@kylinos.cn which does not follow requirements for a *known
> >> identity*. IOW, it does not pass DCO requirements and should not be
> >> accepted.
> > 
> > Do you mean the form
> >   Signed-off-by: songxiebing <songxiebing@kylinos.cn>
> > ?
> > 
> > The name spelling without space is pretty normal in Chinese.
> 
> It is a copy of email username.

... and the username shows the real name in this case :)

> I am no expert, but usually Latin
> transliterations have differences from usernames (and Google confirms
> that space is expected for transliteration, although Google is no expert
> either), so this looks like semi-configured Git.

Yeah, it's possible, but also it's a common pattern, too.

Strictly speaking, it's rather a mistake, and I'm no fan of that
style, too.  OTOH, since it's relatively broadly used and can serve
for denoting the known identity, at least, I took as is.


thanks,

Takashi

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[Krzysztof Kozlowski]

On 31/03/2026 09:54, Lei Huang wrote:
> From: Lei Huang <huanglei@kylinos.cn>
> 
> Fix checkpatch code style errors:
> 
>   ERROR: else should follow close brace '}'
>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>   +       }
>   +       else
> 
> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")

There is no bug to be fixed here. Don't add fake bug indications, it
unnecessarily gives stable team some work.

Drop the tag.

Best regards,
Krzysztof