From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D684630B533
	for <linux-kernel@vger.kernel.org>; Tue, 24 Mar 2026 19:36:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1774381011; cv=none; b=WorALkCELFMFAMqqHlMYipxfZg0H48hu/4fbZddVCz6xNJGit6M61cpyO50Q40GuZM+4hU2ocVsLeQCGCHJ8UgZcZ9TEqNiGg8hHuEzErulMhCV9ew+JLC5injGneXIqWJHstP2KsnDXXlwQ5JGQbRcdHIyl+MARJTnUxxzsE5g=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1774381011; c=relaxed/simple;
	bh=Y0DQCoa8gBGMktVZAyxkmkfzqf+1YN9IBuyzlo0vl/c=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=Q2KaduXE100WiuAMwy36EitE6DeModuChtPe3coc2xoYLEj5oszIB6iyfZijCyNpBNae1U0I8Vq3XetnatQN7/nKdRNd809TTONEypElW4i2UcdmvS5FIzbJShXPEeJ+4gVjTn+CKDNs5UvvPVBO73Qw5V+Sr4BdEmc70q0d4Rs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dc9lN550; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dc9lN550"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15AA2C19424;
	Tue, 24 Mar 2026 19:36:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1774381011;
	bh=Y0DQCoa8gBGMktVZAyxkmkfzqf+1YN9IBuyzlo0vl/c=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
	b=dc9lN550l4+W9+yds7VFGPjTWhQvS9DN8CKESeC+7cgCsbzryAjs3dNytD87jqDOt
	 XxnaL4GVDSUTvJGQCCV1LXy6/w2rDWjTt+cHTHMsGRzXDAHoSlxZmyVKP7GGgPQ9ZM
	 FbFG/wCalXFaPlLCJwmjsFfz/WBCsE4HqtZSkHMLubXd+1Iq8vqqvyMa0d2rW7FcGh
	 bAXV9WxwOjHMobdl6XEhtDCm8Fh88vS3+BX6mCEMEehg4zjuKXV4810QDYRagUghWz
	 LfbrjPJFU2viyH7LCBgkRJBSrt2FTWNxK0ON/WxmLsu0v9fPOemy9R3V6+o15Ju2PL
	 L0ng/NLItYBig==
From: Thomas Gleixner <tglx@kernel.org>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>,
 Anna-Maria Behnsen
 <anna-maria@linutronix.de>, Frederic Weisbecker <frederic@kernel.org>,
 Andy Lutomirski <luto@kernel.org>, Vincenzo Frascino
 <vincenzo.frascino@arm.com>
Cc: linux-kernel@vger.kernel.org, Thomas =?utf-8?Q?Wei=C3=9Fschuh?=
 <thomas.weissschuh@linutronix.de>
Subject: Re: [PATCH 1/2] vdso/timens: Move functions to new file
In-Reply-To: <20260323-vdso-timens-decoupling-v1-1-0181a809b7a6@linutronix.de>
References: <20260323-vdso-timens-decoupling-v1-0-0181a809b7a6@linutronix.de>
 <20260323-vdso-timens-decoupling-v1-1-0181a809b7a6@linutronix.de>
Date: Tue, 24 Mar 2026 20:36:48 +0100
Message-ID: <877br1ggtr.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 23 2026 at 09:07, Thomas Wei=C3=9Fschuh wrote:
> +static void timens_set_vvar_page(struct task_struct *task,
> +				struct time_namespace *ns)
> +{
> +	struct vdso_time_data *vdata;
> +	struct vdso_clock *vc;
> +	unsigned int i;
> +
> +	if (ns =3D=3D &init_time_ns)
> +		return;
> +
> +	/* Fast-path, taken by every task in namespace except the first. */
> +	if (likely(ns->frozen_offsets))
> +		return;
> +
> +	mutex_lock(&timens_offset_lock);

Please convert all the locking to guard() while at it.

Thanks,

        tglx