public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>, ysard <ysard_git@gmx.fr>
Cc: linux-kernel@vger.kernel.org, senozhatsky@chromium.org
Subject: Re: Regression: system freeze on resume from suspend introduced by printk per-console suspended state
Date: Wed, 28 Jan 2026 16:31:59 +0106	[thread overview]
Message-ID: <877bt1lpx4.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <aXoWiJhcOaGGlcmk@pathway.suse.cz>

On 2026-01-28, Petr Mladek <pmladek@suse.com> wrote:
> But I have found a bug in John's debug patch from
> https://lore.kernel.org/all/877bts1ltv.fsf@jogness.linutronix.de/
>
> The patch tried to restore the original behavior on current mainline.
> But console_suspend()/cosnole_resume() function have been renamed recently
> to console_suspend_all()/console_resume_all(). The original
> names were used for console-specific suspend/resume variants,
> see
> https://lore.kernel.org/all/20250226-printk-renaming-v1-0-0b878577f2e6@suse.com/
>
> Also the debug patch did not revert synchronize_srcu(). I guess that
> this was intentional.

I was also concerned about synchronize_srcu() being the culprit, which
is why I left it in. I was really surprised the test patch still had
problems.

> But I would rather revert it as well because
> it is a potentially blocking operation.
>
> Could you please test it with this fixed version of the debug patch?
>
> If the patch helps, by chance, then please try to uncomment
> the synchronize_srcu() calls and check if it still works.

Also, if the patch still has the problem, it would be nice to see the
dmesg output with the patch applied when you do only the nvidia
suspend/resume and avoid systemctl.

> I wonder if they make in difference.

Thanks Petr for the new patch version. I am curious what comes of it.

John

  reply	other threads:[~2026-01-28 15:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-21 22:42 Regression: system freeze on resume from suspend introduced by printk per-console suspended state ysard_git
2025-12-23  6:20 ` John Ogness
     [not found]   ` <trinity-43147d5d-a8ea-47c1-9f83-b578c346b387-1766479103562@3c-app-mailcom-bs12>
2026-01-08  0:05     ` pv
2026-01-08  9:43       ` John Ogness
2026-01-23  7:44         ` ysard
2026-01-23 12:19           ` Petr Mladek
2026-01-24  1:22             ` ysard
2026-01-28 14:00               ` Petr Mladek
2026-01-28 15:25                 ` John Ogness [this message]
2026-01-29  9:34                 ` ysard
2026-01-30 15:56                   ` Petr Mladek
2026-01-30 16:28                     ` Petr Mladek
2026-01-31 22:22                       ` ysard
2026-02-02 11:02                         ` Petr Mladek
2026-02-03  1:32                           ` ysard
2026-02-03 14:11                             ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877bt1lpx4.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=senozhatsky@chromium.org \
    --cc=ysard_git@gmx.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox