From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4D02C0296 for ; Wed, 12 Nov 2025 10:35:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762943714; cv=none; b=lFSNqWr3+a6PIraLwjuzJDsp1ciK0ZYzgWykd1XXOHWRIEdTRLAeomi8fWM2ABqLuagHDyvCrRMJ5+vTUVR67j5FIHx4CD7jIx7uDpW8Jxjdn0nMtm+HqdpRi2vwV22Hz48DW0wPj0WzFUfpRRMi9UI82QPBUfrp2BjZiyP8b5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762943714; c=relaxed/simple; bh=E+tvlKSlf/4Wz9KSvYrxWC/QgGC9Mmj94VvKntU4n/A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=MsIWCHxxRUnH7QiRho4VChg+kBkkJiJcejlKwtEBfeEA39CtrxmMixM+OOoMPbHVTPcJ2tz2tuUf1zN6ouzKxJ9RnBS53sr2dzz4uW2ewWH52SqVq6DcRt2hUknxk56IzljCOGXy5wOrW+hyG42UlQTSfx4AhdDuSEgd0LWa/pI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=djVxInjL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=O/xEfp7Y; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="djVxInjL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="O/xEfp7Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762943711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E+tvlKSlf/4Wz9KSvYrxWC/QgGC9Mmj94VvKntU4n/A=; b=djVxInjLuLu9rPixoAOJG3jcdCyUpkESYda4kSVX+m5f7FB2FM69sLZ51a6bZAJN5gPTYo DuyOeF8mYB5A1buDhgq64TZM21lGzORUKgofE9zieK6orpUtF6cM7GqPwKut0D41k/gkas HgOvn5IZGjB0A6shTbovZsR7SCLTtx8= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-bdh73W_sOnKUcQCyrNWumw-1; Wed, 12 Nov 2025 05:35:10 -0500 X-MC-Unique: bdh73W_sOnKUcQCyrNWumw-1 X-Mimecast-MFC-AGG-ID: bdh73W_sOnKUcQCyrNWumw_1762943709 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b732e399c67so64650266b.1 for ; Wed, 12 Nov 2025 02:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762943709; x=1763548509; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=E+tvlKSlf/4Wz9KSvYrxWC/QgGC9Mmj94VvKntU4n/A=; b=O/xEfp7YWmTmvHPNePKBPS7LOLgpU6Rh/qjwQolnaee3YDJcfoNHYlc6hLUklp/WQm 0cDIiAV5Tg8D6Kgk5Rvdz1/B0rxC9x7xim1rvQ6giiIAZxM7/tYTc5NbyFlClqu4q8Ns D0AelqmdOAZQRFfxLYfgndSoJdfUrd/vlgnypx58P3WqFkz4OdYn6ZFUWxRXp9GYrQtb RciT85XY9v7bTFkaWoI2GCj3AEL7Oo0orIKqtF5YI3DZDyK8xR8HAdl7SrsnacjTm9ir mu88aBxtMmysQSaqE10yFZdNCWrb45I8Bd/Vq0A2JI/Pv8YKnLt8yobxlNa1+568bDG8 NxLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762943709; x=1763548509; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E+tvlKSlf/4Wz9KSvYrxWC/QgGC9Mmj94VvKntU4n/A=; b=VL/pse5v2t0zraiYnBerQ9DuI/Wr1oQU3G857IgeZX2tAwDUN8DE/S5P7lS4Qx9wPU wYrwmaDzj/Wxks1D0dj9yo/sLGz1Nntan128MILUvEAzOXuvFNQMVRqQnOsTis+7rdU2 DeIEXgzs3YBXvqQOBw3M2Y07VfMxjW8DOn4+N1ISFcvuNV+SdC2Ll5WKm6APLtGPkNT1 dVqNW1ntcPSsUkO7kBeEdqQ0QWSJGG/tkZYPpDeLRIqUJcmHWhijQ7fEylqDJkeCG8Y8 9X4621yuAoBKX6kEhIFBEngW49khGXmRvui/hACKc4oVZqtR1fukrqvYhgSXw8pBhuFY p5fg== X-Forwarded-Encrypted: i=1; AJvYcCWvk/aQOQvGruYa4d855TVQ9ryHz3xJx6bauuqFX15wxlIYyCNvcAcIcg0LhCtbtpqSAhaxXQWDLOya/Lg=@vger.kernel.org X-Gm-Message-State: AOJu0YwOJz1NNifQgmcZnOZIaDuexZVetPE8YXgubvJILDU8voSvCTW7 Pg4CaHa7OC8OIeqUFVCt6RVGWQE+vzxCNlkFnNpfBDj9wHZoNpjQi11oRkQkDgbA6oPI+t+0uxm LXeGi04n2jlMFl9BDjs0ayXyO7YWIyOAwp6SWhCtlnkWUnIxkRgo9hLtHwrVTC7RtXw== X-Gm-Gg: ASbGncs9sIcVKMcpmQwpnwJXrfetWzQGBzMN83TlN3tYwp4UDvvgO4hgRUSTZqSOYun SnQ39p/l5U8cpmjqh55eMDOgiw99r6Mg5Y5Fl59hW8cOmHlzIuAg2CV8Pp/dqsepCgg6O+8x+2O vweNJcMMKEqRqUKerpe9MvgFA2NUEet+Itj09W0mI4nQnDjygubg/Yo1jkOJ4UNglQvEiMSuQIk Gul9ZimTbwbDgPP9QuT1ppWKCulV2/XRim7YNSoeHqm4LGkM5wzCNXJPd6HrfqqKTZQfvLBwBz2 M1qlUlgMTqI7fzpO1gRgrVslHPL0cflQglsHW9zy9+7Z+U7FXQ4EPMN6HmRigmTIvwuT1myDWtf OzNaf8Rx+S5Z7YvyWNWH0Ggs= X-Received: by 2002:a17:907:c1c:b0:b49:5103:c0b4 with SMTP id a640c23a62f3a-b7331ace073mr291847066b.56.1762943709059; Wed, 12 Nov 2025 02:35:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IE0/W7QILhc20zuI/PbypJ8sMQLsdF6TH22S7u7UG3VgCM2TlPgQLQWKEl5Bf/jjsWA11F+4Q== X-Received: by 2002:a17:907:c1c:b0:b49:5103:c0b4 with SMTP id a640c23a62f3a-b7331ace073mr291842966b.56.1762943708631; Wed, 12 Nov 2025 02:35:08 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64179499189sm8607152a12.8.2025.11.12.02.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Nov 2025 02:35:07 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 2C7A2329674; Wed, 12 Nov 2025 11:29:54 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Tariq Toukan , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" Cc: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Gal Pressman , Leon Romanovsky , Moshe Shemesh , William Tu , Dragos Tatulea , Nimrod Oren , Alex Lazar Subject: Re: [PATCH net-next 6/6] net/mlx5e: Support XDP target xmit with dummy program In-Reply-To: <1762939749-1165658-7-git-send-email-tariqt@nvidia.com> References: <1762939749-1165658-1-git-send-email-tariqt@nvidia.com> <1762939749-1165658-7-git-send-email-tariqt@nvidia.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 12 Nov 2025 11:29:54 +0100 Message-ID: <877bvvlf19.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Tariq Toukan writes: > Save per-channel resources in default. > > As no better API exist, make the XDP-redirect-target SQ available by > loading a dummy XDP program. This is a user-visible change, though, no? I.e., after this patch xdp_redirect mlx5 devices will no longer work as an xdp_redirect target out of the box? We have userspace code listing the driver support in various places (e.g., here in xdp-tools: https://github.com/xdp-project/xdp-tools/commit/1dad1d6e0ccb086b8a31496931f21a165b42b700); I'm sure there will be other places. Since such code would up until now assume that mlx5 just works, this will end up being a regression in such cases, no? -Toke