From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Ingo Molnar" <mingo@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Frederic Weisbecker" <frederic@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Lyude Paul" <lyude@redhat.com>,
"Miguel Ojeda" <ojeda@kernel.org>
Subject: Re: [PATCH 01/10] rust: Rename timer_container_of() to hrtimer_container_of()
Date: Tue, 22 Apr 2025 14:08:37 +0200 [thread overview]
Message-ID: <877c3cbdq2.fsf@kernel.org> (raw)
In-Reply-To: <20250416090544.3311613-2-mingo@kernel.org> (Ingo Molnar's message of "Wed, 16 Apr 2025 11:05:35 +0200")
Hi Ingo,
"Ingo Molnar" <mingo@kernel.org> writes:
> This primitive is dealing with 'struct hrtimer' objects, not
> 'struct timer_list' objects - so clarify the name.
>
> We want to introduce the timer_container_of() symbol in the kernel
> for timer_list, make sure there's no clash of namespaces, at least
> on the conceptual plane.
This associated trait function is defined on the trait `HasHrTimer`, so
I don't think there is any risk of confusing it with the C (or future
Rust) `timer_container_of` methods/functions.
As to symbol names, there is no risk of conflicts. The rust symbols are
mangled and get quite long.
If you really want this change it's OK with me, but I would prefer to
drop it.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-04-22 12:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 9:05 [PATCH -v2 00/10] timers: Simple cleanup of the timer API namespace Ingo Molnar
2025-04-16 9:05 ` [PATCH 01/10] rust: Rename timer_container_of() to hrtimer_container_of() Ingo Molnar
2025-04-16 13:29 ` Miguel Ojeda
2025-04-18 7:13 ` Ingo Molnar
2025-04-22 12:08 ` Andreas Hindborg [this message]
2025-04-16 9:05 ` [PATCH 02/10] treewide, timers: Rename from_timer() => timer_container_of() Ingo Molnar
2025-04-16 9:05 ` [PATCH 03/10] treewide, timers: Rename try_to_del_timer_sync() => timer_delete_sync_try() Ingo Molnar
2025-04-16 9:05 ` [PATCH 04/10] treewide, timers: Rename destroy_timer_on_stack() => timer_destroy_on_stack() Ingo Molnar
2025-04-16 9:05 ` [PATCH 05/10] treewide, timers: Rename init_timer_key() => timer_init_key() Ingo Molnar
2025-04-16 9:05 ` [PATCH 06/10] treewide, timers: Rename init_timer_on_stack_key() => timer_init_key_on_stack() Ingo Molnar
2025-04-16 9:05 ` [PATCH 07/10] treewide, timers: Rename __init_timer() => __timer_init() Ingo Molnar
2025-04-16 9:05 ` [PATCH 08/10] treewide, timers: Rename __init_timer_on_stack() => __timer_init_on_stack() Ingo Molnar
2025-04-16 9:05 ` [PATCH 09/10] treewide, timers: Rename NEXT_TIMER_MAX_DELTA => TIMER_NEXT_MAX_DELTA Ingo Molnar
2025-04-16 9:05 ` [PATCH 10/10] treewide, timers: Rename init_timers() => timers_init() Ingo Molnar
2025-04-18 7:31 ` [PATCH -v2 00/10] timers: Simple cleanup of the timer API namespace Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2025-05-07 17:53 Ingo Molnar
2025-05-07 17:53 ` [PATCH 01/10] rust: Rename timer_container_of() to hrtimer_container_of() Ingo Molnar
2025-05-07 18:04 ` Andreas Hindborg
2025-05-07 19:38 ` Ingo Molnar
2025-05-12 9:29 ` Andreas Hindborg
2025-05-12 10:33 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c3cbdq2.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=anna-maria@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=mingo@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).