From: Thomas Gleixner <tglx@linutronix.de>
To: Eric Dumazet <edumazet@google.com>, Mateusz Guzik <mjguzik@gmail.com>
Cc: kernel test robot <oliver.sang@intel.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
Benjamin Segall <bsegall@google.com>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [tip:timers/core] [posix] 1535cb8028: stress-ng.epoll.ops_per_sec 36.2% regression
Date: Thu, 27 Mar 2025 09:10:44 +0100 [thread overview]
Message-ID: <877c4azyez.ffs@tglx> (raw)
In-Reply-To: <CANn89iKjCgmxtiLeVAiXODHbbR7=gYYi5cfAS1hS5qn+z=-o1Q@mail.gmail.com>
On Thu, Mar 27 2025 at 07:21, Eric Dumazet wrote:
> On Wed, Mar 26, 2025 at 10:11 PM Mateusz Guzik <mjguzik@gmail.com> wrote:
>> On Wed, Mar 26, 2025 at 09:07:51AM +0100, Thomas Gleixner wrote:
>> > Unfortunately I can't reproduce any of it. I checked the epoll test
>> > source and it uses a posix timer, but that commit makes the hash less
>> > contended so there is zero explanation.
>> >
>>
>> The short summary is:
>> 1. your change is fine
>
> Let me rephrase this.
>
> Absolutely wonderful series, thanks a lot Thomas for doing it.
Thank you!
> Next bottlenecks are now these ones, but showing up in synthetic
> benchmarks only.
Right. I saw them too when working on this.
> 33.36% timer_storm [kernel.kallsyms] [k]
> inc_rlimit_get_ucounts
>
> 32.85% timer_storm [kernel.kallsyms] [k]
> dec_rlimit_put_ucounts
These two are not really posix-timer specific. They are also the
standouts for any signal micro benchmark.
I stared at the implementation a bit, but there is not much we can do
about that I fear.
Thanks,
tglx
next prev parent reply other threads:[~2025-03-27 8:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 6:39 [tip:timers/core] [posix] 1535cb8028: stress-ng.epoll.ops_per_sec 36.2% regression kernel test robot
2025-03-26 8:07 ` Thomas Gleixner
2025-03-26 21:11 ` Mateusz Guzik
2025-03-26 21:43 ` Thomas Gleixner
2025-03-27 6:21 ` Eric Dumazet
2025-03-27 8:10 ` Thomas Gleixner [this message]
2025-03-27 8:26 ` Eric Dumazet
2025-03-27 9:11 ` Eric Dumazet
2025-03-27 10:50 ` Thomas Gleixner
2025-03-27 11:37 ` Eric Dumazet
2025-03-27 13:14 ` Thomas Gleixner
2025-03-27 13:17 ` Eric Dumazet
2025-03-27 13:43 ` Mateusz Guzik
2025-03-27 13:44 ` Eric Dumazet
2025-03-27 13:48 ` Mateusz Guzik
2025-03-27 20:45 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c4azyez.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bsegall@google.com \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mjguzik@gmail.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox