Re: [PATCH v9 04/13] rust: hrtimer: allow timer restart from timer handler

[Andreas Hindborg <a.hindborg@kernel.org>]

"Lyude Paul" <lyude@redhat.com> writes:

> On Mon, 2025-02-24 at 13:03 +0100, Andreas Hindborg wrote:
>> This patch allows timer handlers to report that they want a timer to be
>> restarted after the timer handler has finished executing.
>>
>> Also update the `hrtimer` documentation to showcase the new feature.
>>
>> Acked-by: Frederic Weisbecker <frederic@kernel.org>
>> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
>> ---
>>  rust/kernel/time/hrtimer.rs     | 19 ++++++++++++++++++-
>>  rust/kernel/time/hrtimer/arc.rs |  4 +---
>>  2 files changed, 19 insertions(+), 4 deletions(-)
>>
>> diff --git a/rust/kernel/time/hrtimer.rs b/rust/kernel/time/hrtimer.rs
>> index d08fd7de158d..a431c8b728ae 100644
>> --- a/rust/kernel/time/hrtimer.rs
>> +++ b/rust/kernel/time/hrtimer.rs
>> @@ -207,7 +207,7 @@ pub trait HrTimerCallback {
>>      type Pointer<'a>: RawHrTimerCallback;
>>
>>      /// Called by the timer logic when the timer fires.
>> -    fn run(this: <Self::Pointer<'_> as RawHrTimerCallback>::CallbackTarget<'_>)
>> +    fn run(this: <Self::Pointer<'_> as RawHrTimerCallback>::CallbackTarget<'_>) -> HrTimerRestart
>>      where
>>          Self: Sized;
>>  }
>> @@ -313,6 +313,23 @@ unsafe fn start(self_ptr: *const Self, expires: Ktime) {
>>      }
>>  }
>>
>> +/// Restart policy for timers.
>> +pub enum HrTimerRestart {
>> +    /// Timer should not be restarted.
>> +    NoRestart,
>> +    /// Timer should be restarted.
>> +    Restart,
>> +}
>
> Should we have #[derive(Copy, Clone, PartialEq, Eq)] here?

Yea, lets do that. `Debug` as well?

>
> Also, I feel like I might have asked this a few versions ago so hopefully i'm
> not asking again: but what's the reason for us not just using the
> discriminants of `HrTimerRestart` here:
>
> /// Restart policy for timers.
> #[repr(u32)]
> pub enum HrTimerRestart {
>     /// Timer should not be restarted.
>     NoRestart = bindings::hrtimer_restart_HRTIMER_NORESTART,
>     /// Timer should be restarted.
>     Restart = bindings::hrtimer_restart_HRTIMER_RESTART,
> }

I forget if we discussed this, but it does not make much of a
difference, does it?

With a Rust enum, we get a smaller storage type maybe with better
support for niche optimizations? And then pay a bit more for conversion.
All in all, I don't think it makes much difference.


Best regards,
Andreas Hindborg