From: Sam James <sam@gentoo.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Kees Cook <kees@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Kostadin Shishmanov <kostadinshishmanov@protonmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
arnd@arndb.de, linux-kbuild@vger.kernel.org
Subject: Re: Build failure with GCC 15 (-std=gnu23)
Date: Tue, 21 Jan 2025 22:11:56 +0000 [thread overview]
Message-ID: <877c6n24wj.fsf@gentoo.org> (raw)
In-Reply-To: <20250121215330.GB1517789@ax162> (Nathan Chancellor's message of "Tue, 21 Jan 2025 14:53:30 -0700")
Nathan Chancellor <nathan@kernel.org> writes:
> On Mon, Jan 20, 2025 at 04:16:30PM -0800, Kees Cook wrote:
>> On Wed, Nov 20, 2024 at 03:28:35AM +0900, Masahiro Yamada wrote:
>> > Some Makefile overriding KBUILD_CFLAGS would forget to add
>> > $(CSTD_FLAG), for the same reason as they would forget to add
>> > -std=gnu11.
>>
>> But at least we'd have 1 place to change when we changed the std level.
>>
>> FWIW, I just ran into this build failure too testing GCC 15 from their
>> ToT. Both EFI and compressed Makefiles needed it in my build.
>
> Yeah, I suggested the simpler diff in a separate thread, which seems to
> agree with your testing:
>
> https://lore.kernel.org/20250120182048.GA3244701@ax162/
>
> I don't mind drafting up a commit message and sending those along if
> that would be preferrable.
At this point, I'd like to see the scattered -std= in given it seems
less objectionable, even if I'd prefer one place, as we already missed
one release being GCC 15-buildable. Happy to test/ack it if you're willing to send it.
thanks,
sam
next prev parent reply other threads:[~2025-01-21 22:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 14:26 Build failure with GCC 15 (-std=gnu23) Kostadin Shishmanov
2024-11-18 20:56 ` Nathan Chancellor
2024-11-19 2:57 ` Sam James
2024-11-19 4:15 ` Nathan Chancellor
2024-11-19 4:24 ` Sam James
2024-11-19 4:47 ` Nathan Chancellor
2024-11-19 18:28 ` Masahiro Yamada
2025-01-21 0:16 ` Kees Cook
2025-01-21 21:53 ` Nathan Chancellor
2025-01-21 22:11 ` Sam James [this message]
2025-01-21 22:51 ` Nathan Chancellor
2024-11-19 6:53 ` Arnd Bergmann
2024-11-19 14:18 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c6n24wj.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=arnd@arndb.de \
--cc=kees@kernel.org \
--cc=kostadinshishmanov@protonmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox