From: Kalle Valo <kvalo@kernel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v2 16/22] wifi: ath12k: convert tasklet to BH workqueue for CE interrupts
Date: Mon, 21 Oct 2024 12:06:37 +0300 [thread overview]
Message-ID: <877ca1q0yq.fsf@kernel.org> (raw)
In-Reply-To: <20241015182637.955753-17-quic_rajkbhag@quicinc.com> (Raj Kumar Bhagat's message of "Tue, 15 Oct 2024 23:56:31 +0530")
Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> writes:
> Currently in Ath12k, tasklet is used to handle the BH context of CE
> interrupts. However the tasklet is marked deprecated and has some
> design flaws. To replace tasklets, BH workqueue support has been
> added. BH workqueue behaves similarly to regular workqueues except
> that the queued work items are executed in the BH context.
>
> Hence, convert the tasklet to BH workqueue for handling CE interrupts
> in the BH context.
>
> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00210-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
22 patches is a lot and I'm not going to look at this in detail, please
reduce your patchset size. 10-12 patches is recommended. For example,
this could be easily submitted separately.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-10-21 9:06 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 18:26 [PATCH v2 00/22] wifi: ath12k: add Ath12k AHB driver support for IPQ5332 Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 01/22] dt-bindings: net: wireless: describe the ath12k AHB module Raj Kumar Bhagat
2024-10-16 7:02 ` Krzysztof Kozlowski
2024-10-16 8:37 ` Raj Kumar Bhagat
2024-10-16 9:00 ` Krzysztof Kozlowski
2024-11-27 7:24 ` Raj Kumar Bhagat
2024-10-16 10:28 ` Dmitry Baryshkov
2024-12-03 9:07 ` Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 02/22] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441 Raj Kumar Bhagat
2024-10-16 6:58 ` Krzysztof Kozlowski
2024-10-16 8:48 ` Raj Kumar Bhagat
2024-10-16 10:30 ` Dmitry Baryshkov
2024-10-16 10:55 ` Krzysztof Kozlowski
2024-10-16 11:13 ` Dmitry Baryshkov
2024-10-15 18:26 ` [PATCH v2 03/22] wifi: ath12k: add ath12k_hw_params for IPQ5332 Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 04/22] wifi: ath12k: refactor ath12k_hw_regs structure Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 05/22] wifi: ath12k: add ath12k_hw_regs for IPQ5332 Raj Kumar Bhagat
2024-10-18 19:58 ` Konrad Dybcio
2024-12-03 9:07 ` Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 06/22] wifi: ath12k: add ath12k_hw_ring_mask " Raj Kumar Bhagat
2024-10-18 19:59 ` Konrad Dybcio
2024-10-15 18:26 ` [PATCH v2 07/22] wifi: ath12k: add CE configurations " Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 08/22] wifi: ath12k: add ath12k_hw_hal_params " Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 09/22] wifi: ath12k: avoid m3 firmware download in AHB device IPQ5332 Raj Kumar Bhagat
2024-10-18 20:00 ` Konrad Dybcio
2024-12-03 9:11 ` Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 10/22] wifi: ath12k: add new CMEM read-write ath12k_hif_ops Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 11/22] wifi: ath12k: remap CMEM register space for IPQ5332 Raj Kumar Bhagat
2024-10-18 20:09 ` Konrad Dybcio
2024-10-15 18:26 ` [PATCH v2 12/22] wifi: ath12k: fix incorrect CE addresses Raj Kumar Bhagat
2024-10-18 20:02 ` Konrad Dybcio
2024-12-03 9:12 ` Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 13/22] wifi: ath12k: remap CE register space for IPQ5332 Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 14/22] wifi: ath12k: add support for fixed QMI firmware memory Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 15/22] wifi: ath12k: add BDF address in hardware parameter Raj Kumar Bhagat
2024-11-04 14:16 ` Konrad Dybcio
2024-12-03 9:18 ` Raj Kumar Bhagat
2024-12-05 17:42 ` Konrad Dybcio
2024-12-06 4:34 ` Raj Kumar Bhagat
2024-12-06 10:49 ` Konrad Dybcio
2024-12-09 4:23 ` Raj Kumar Bhagat
2024-12-13 0:18 ` Konrad Dybcio
2024-12-13 4:29 ` Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 16/22] wifi: ath12k: convert tasklet to BH workqueue for CE interrupts Raj Kumar Bhagat
2024-10-21 9:06 ` Kalle Valo [this message]
2024-10-22 7:13 ` Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 17/22] wifi: ath12k: add AHB driver support for IPQ5332 Raj Kumar Bhagat
2024-10-18 20:29 ` Konrad Dybcio
2024-12-06 9:56 ` Raj Kumar Bhagat
2024-12-06 11:46 ` Konrad Dybcio
2024-12-06 10:00 ` Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 18/22] wifi: ath12k: Power up root PD Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 19/22] wifi: ath12k: Register various userPD interrupts and save SMEM entries Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 20/22] wifi: ath12k: Power up userPD Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 21/22] wifi: ath12k: Power down userPD Raj Kumar Bhagat
2024-10-15 18:26 ` [PATCH v2 22/22] wifi: ath12k: enable ath12k AHB support Raj Kumar Bhagat
2024-10-16 6:57 ` [PATCH v2 00/22] wifi: ath12k: add Ath12k AHB driver support for IPQ5332 Krzysztof Kozlowski
2024-12-06 11:07 ` Raj Kumar Bhagat
2024-12-06 12:55 ` Krzysztof Kozlowski
2024-12-08 13:45 ` Raj Kumar Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ca1q0yq.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=andersson@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jjohnson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rajkbhag@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox