From: Takashi Iwai <tiwai@suse.de>
To: Julian Vetter <jvetter@kalrayinc.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>,
Yann Sionneau <ysionneau@kalrayinc.com>
Subject: Re: [PATCH] sound: Make CONFIG_SND depend on INDIRECT_IOMEM instead of UML
Date: Thu, 10 Oct 2024 16:12:08 +0200 [thread overview]
Message-ID: <877cag11zb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20241010124601.700528-1-jvetter@kalrayinc.com>
On Thu, 10 Oct 2024 14:46:01 +0200,
Julian Vetter wrote:
>
> When building for the UM arch and neither INDIRECT_IOMEM=y, nor
> HAS_IOMEM=y is selected, it will fall back to the implementations from
> asm-generic/io.h for IO memcpy. But these fall-back functions just do a
> memcpy. So, instead of depending on UML, add dependency on 'HAS_IOMEM ||
> INDIRECT_IOMEM'.
>
> Acked-by: Takashi Iwai <tiwai@suse.de>
> Reviewed-by: Yann Sionneau <ysionneau@kalrayinc.com>
> Signed-off-by: Julian Vetter <jvetter@kalrayinc.com>
This is expected to be applied via sound.git tree?
Then I'll happily take it.
thanks,
Takashi
> ---
> sound/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/Kconfig b/sound/Kconfig
> index 4c036a9a420a..8b40205394fe 100644
> --- a/sound/Kconfig
> +++ b/sound/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> menuconfig SOUND
> tristate "Sound card support"
> - depends on HAS_IOMEM || UML
> + depends on HAS_IOMEM || INDIRECT_IOMEM
> help
> If you have a sound card in your computer, i.e. if it can say more
> than an occasional beep, say Y.
> --
> 2.34.1
>
>
>
>
>
next prev parent reply other threads:[~2024-10-10 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 12:46 [PATCH] sound: Make CONFIG_SND depend on INDIRECT_IOMEM instead of UML Julian Vetter
2024-10-10 14:12 ` Takashi Iwai [this message]
2024-10-10 14:53 ` Julian Vetter
2024-10-10 14:59 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cag11zb.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=jvetter@kalrayinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=ysionneau@kalrayinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox