* [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk
@ 2024-09-12 15:26 Joshua Pius
2024-09-12 16:01 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Joshua Pius @ 2024-09-12 15:26 UTC (permalink / raw)
To: alsa-devel
Cc: Joshua Pius, Joshua Pius, Jaroslav Kysela, Takashi Iwai,
Karol Kosik, Steven 'Steve' Kendall, linux-sound,
linux-kernel
Specify shortnames for the following Logitech Devices: Rally bar, Rally
bar mini, Tap, MeetUp and Huddle.
Signed-off-by: Joshua Pius <joshuapius@chromium.org>
---
sound/usb/card.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/sound/usb/card.c b/sound/usb/card.c
index 778de9244f1e..9c411b82a218 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -384,6 +384,12 @@ static const struct usb_audio_device_name usb_audio_names[] = {
/* Creative/Toshiba Multimedia Center SB-0500 */
DEVICE_NAME(0x041e, 0x3048, "Toshiba", "SB-0500"),
+ /* Logitech Audio Devices */
+ DEVICE_NAME(0x046d, 0x0867, "Logitech, Inc.", "Logi-MeetUp"),
+ DEVICE_NAME(0x046d, 0x0874, "Logitech, Inc.", "Logi-Tap-Audio"),
+ DEVICE_NAME(0x046d, 0x087c, "Logitech, Inc.", "Logi-Huddle"),
+ DEVICE_NAME(0x046d, 0x0898, "Logitech, Inc.", "Logi-RB-Audio"),
+ DEVICE_NAME(0x046d, 0x08d2, "Logitech, Inc.", "Logi-RBM-Audio"),
DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"),
DEVICE_NAME(0x05e1, 0x0408, "Syntek", "STK1160"),
--
2.46.0.598.g6f2099f65c-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk
2024-09-12 15:26 [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk Joshua Pius
@ 2024-09-12 16:01 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2024-09-12 16:01 UTC (permalink / raw)
To: Joshua Pius
Cc: alsa-devel, Joshua Pius, Jaroslav Kysela, Takashi Iwai,
Karol Kosik, Steven 'Steve' Kendall, linux-sound,
linux-kernel
On Thu, 12 Sep 2024 17:26:28 +0200,
Joshua Pius wrote:
>
> Specify shortnames for the following Logitech Devices: Rally bar, Rally
> bar mini, Tap, MeetUp and Huddle.
>
> Signed-off-by: Joshua Pius <joshuapius@chromium.org>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk
@ 2024-09-06 21:14 Joshua Pius
2024-09-08 7:48 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Joshua Pius @ 2024-09-06 21:14 UTC (permalink / raw)
To: alsa-devel
Cc: Joshua Pius, Jaroslav Kysela, Takashi Iwai,
Steven 'Steve' Kendall, Karol Kosik, linux-sound,
linux-kernel
Specify shortnames for the following Logitech Devices: Rally bar, Rally
bar mini, Tap, MeetUp and Huddle.
Signed-off-by: Joshua Pius <joshuapius@google.com>
---
sound/usb/card.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/sound/usb/card.c b/sound/usb/card.c
index 778de9244f1e..9c411b82a218 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -384,6 +384,12 @@ static const struct usb_audio_device_name usb_audio_names[] = {
/* Creative/Toshiba Multimedia Center SB-0500 */
DEVICE_NAME(0x041e, 0x3048, "Toshiba", "SB-0500"),
+ /* Logitech Audio Devices */
+ DEVICE_NAME(0x046d, 0x0867, "Logitech, Inc.", "Logi-MeetUp"),
+ DEVICE_NAME(0x046d, 0x0874, "Logitech, Inc.", "Logi-Tap-Audio"),
+ DEVICE_NAME(0x046d, 0x087c, "Logitech, Inc.", "Logi-Huddle"),
+ DEVICE_NAME(0x046d, 0x0898, "Logitech, Inc.", "Logi-RB-Audio"),
+ DEVICE_NAME(0x046d, 0x08d2, "Logitech, Inc.", "Logi-RBM-Audio"),
DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"),
DEVICE_NAME(0x05e1, 0x0408, "Syntek", "STK1160"),
--
2.46.0.598.g6f2099f65c-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk
2024-09-06 21:14 Joshua Pius
@ 2024-09-08 7:48 ` Takashi Iwai
2024-09-09 2:03 ` Joshua Pius
0 siblings, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2024-09-08 7:48 UTC (permalink / raw)
To: Joshua Pius
Cc: alsa-devel, Joshua Pius, Jaroslav Kysela, Takashi Iwai,
Steven 'Steve' Kendall, Karol Kosik, linux-sound,
linux-kernel
On Fri, 06 Sep 2024 23:14:38 +0200,
Joshua Pius wrote:
>
> Specify shortnames for the following Logitech Devices: Rally bar, Rally
> bar mini, Tap, MeetUp and Huddle.
>
> Signed-off-by: Joshua Pius <joshuapius@google.com>
Is this change needed only for UCM profiles? UCM v2 should be able to
handle better to identify models, and such short name updates aren't
needed for them.
OTOH, I don't mind much to take this kind of small harmless changes
(unless it happens too frequently). So I'll likely take this, but
just for verifying the situation.
thanks,
Takashi
> ---
> sound/usb/card.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/sound/usb/card.c b/sound/usb/card.c
> index 778de9244f1e..9c411b82a218 100644
> --- a/sound/usb/card.c
> +++ b/sound/usb/card.c
> @@ -384,6 +384,12 @@ static const struct usb_audio_device_name usb_audio_names[] = {
> /* Creative/Toshiba Multimedia Center SB-0500 */
> DEVICE_NAME(0x041e, 0x3048, "Toshiba", "SB-0500"),
>
> + /* Logitech Audio Devices */
> + DEVICE_NAME(0x046d, 0x0867, "Logitech, Inc.", "Logi-MeetUp"),
> + DEVICE_NAME(0x046d, 0x0874, "Logitech, Inc.", "Logi-Tap-Audio"),
> + DEVICE_NAME(0x046d, 0x087c, "Logitech, Inc.", "Logi-Huddle"),
> + DEVICE_NAME(0x046d, 0x0898, "Logitech, Inc.", "Logi-RB-Audio"),
> + DEVICE_NAME(0x046d, 0x08d2, "Logitech, Inc.", "Logi-RBM-Audio"),
> DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"),
>
> DEVICE_NAME(0x05e1, 0x0408, "Syntek", "STK1160"),
> --
> 2.46.0.598.g6f2099f65c-goog
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk
2024-09-08 7:48 ` Takashi Iwai
@ 2024-09-09 2:03 ` Joshua Pius
2024-09-10 8:26 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Joshua Pius @ 2024-09-09 2:03 UTC (permalink / raw)
To: Takashi Iwai
Cc: Joshua Pius, alsa-devel, Jaroslav Kysela, Takashi Iwai,
Steven 'Steve' Kendall, Karol Kosik, linux-sound,
linux-kernel
Yes, this change is for UCM profiles.
Yes this should be a one time occurrence as afterwards effort is being
made to migrate over to UCM v2.
Thanks,
Joshua P
On Sun, Sep 8, 2024 at 3:47 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Fri, 06 Sep 2024 23:14:38 +0200,
> Joshua Pius wrote:
> >
> > Specify shortnames for the following Logitech Devices: Rally bar, Rally
> > bar mini, Tap, MeetUp and Huddle.
> >
> > Signed-off-by: Joshua Pius <joshuapius@google.com>
>
> Is this change needed only for UCM profiles? UCM v2 should be able to
> handle better to identify models, and such short name updates aren't
> needed for them.
>
> OTOH, I don't mind much to take this kind of small harmless changes
> (unless it happens too frequently). So I'll likely take this, but
> just for verifying the situation.
>
>
> thanks,
>
> Takashi
>
>
> > ---
> > sound/usb/card.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/sound/usb/card.c b/sound/usb/card.c
> > index 778de9244f1e..9c411b82a218 100644
> > --- a/sound/usb/card.c
> > +++ b/sound/usb/card.c
> > @@ -384,6 +384,12 @@ static const struct usb_audio_device_name usb_audio_names[] = {
> > /* Creative/Toshiba Multimedia Center SB-0500 */
> > DEVICE_NAME(0x041e, 0x3048, "Toshiba", "SB-0500"),
> >
> > + /* Logitech Audio Devices */
> > + DEVICE_NAME(0x046d, 0x0867, "Logitech, Inc.", "Logi-MeetUp"),
> > + DEVICE_NAME(0x046d, 0x0874, "Logitech, Inc.", "Logi-Tap-Audio"),
> > + DEVICE_NAME(0x046d, 0x087c, "Logitech, Inc.", "Logi-Huddle"),
> > + DEVICE_NAME(0x046d, 0x0898, "Logitech, Inc.", "Logi-RB-Audio"),
> > + DEVICE_NAME(0x046d, 0x08d2, "Logitech, Inc.", "Logi-RBM-Audio"),
> > DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"),
> >
> > DEVICE_NAME(0x05e1, 0x0408, "Syntek", "STK1160"),
> > --
> > 2.46.0.598.g6f2099f65c-goog
> >
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk
2024-09-09 2:03 ` Joshua Pius
@ 2024-09-10 8:26 ` Takashi Iwai
2024-09-11 19:27 ` Joshua Pius
0 siblings, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2024-09-10 8:26 UTC (permalink / raw)
To: Joshua Pius
Cc: Joshua Pius, alsa-devel, Jaroslav Kysela, Takashi Iwai,
Steven 'Steve' Kendall, Karol Kosik, linux-sound,
linux-kernel
On Mon, 09 Sep 2024 04:03:36 +0200,
Joshua Pius wrote:
>
> Yes, this change is for UCM profiles.
>
> Yes this should be a one time occurrence as afterwards effort is being
> made to migrate over to UCM v2.
OK, then I'll take it. But, I noticed that your Signed-off-by tag was
with google.com address while you submitted from chromium.org.
Could you align those?
thanks,
Takashi
>
> Thanks,
>
> Joshua P
>
>
>
>
>
> On Sun, Sep 8, 2024 at 3:47 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Fri, 06 Sep 2024 23:14:38 +0200,
> > Joshua Pius wrote:
> > >
> > > Specify shortnames for the following Logitech Devices: Rally bar, Rally
> > > bar mini, Tap, MeetUp and Huddle.
> > >
> > > Signed-off-by: Joshua Pius <joshuapius@google.com>
> >
> > Is this change needed only for UCM profiles? UCM v2 should be able to
> > handle better to identify models, and such short name updates aren't
> > needed for them.
> >
> > OTOH, I don't mind much to take this kind of small harmless changes
> > (unless it happens too frequently). So I'll likely take this, but
> > just for verifying the situation.
> >
> >
> > thanks,
> >
> > Takashi
> >
> >
> > > ---
> > > sound/usb/card.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/sound/usb/card.c b/sound/usb/card.c
> > > index 778de9244f1e..9c411b82a218 100644
> > > --- a/sound/usb/card.c
> > > +++ b/sound/usb/card.c
> > > @@ -384,6 +384,12 @@ static const struct usb_audio_device_name usb_audio_names[] = {
> > > /* Creative/Toshiba Multimedia Center SB-0500 */
> > > DEVICE_NAME(0x041e, 0x3048, "Toshiba", "SB-0500"),
> > >
> > > + /* Logitech Audio Devices */
> > > + DEVICE_NAME(0x046d, 0x0867, "Logitech, Inc.", "Logi-MeetUp"),
> > > + DEVICE_NAME(0x046d, 0x0874, "Logitech, Inc.", "Logi-Tap-Audio"),
> > > + DEVICE_NAME(0x046d, 0x087c, "Logitech, Inc.", "Logi-Huddle"),
> > > + DEVICE_NAME(0x046d, 0x0898, "Logitech, Inc.", "Logi-RB-Audio"),
> > > + DEVICE_NAME(0x046d, 0x08d2, "Logitech, Inc.", "Logi-RBM-Audio"),
> > > DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"),
> > >
> > > DEVICE_NAME(0x05e1, 0x0408, "Syntek", "STK1160"),
> > > --
> > > 2.46.0.598.g6f2099f65c-goog
> > >
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk
2024-09-10 8:26 ` Takashi Iwai
@ 2024-09-11 19:27 ` Joshua Pius
2024-09-12 7:23 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Joshua Pius @ 2024-09-11 19:27 UTC (permalink / raw)
To: Takashi Iwai
Cc: Joshua Pius, alsa-devel, Jaroslav Kysela, Takashi Iwai,
Steven 'Steve' Kendall, Karol Kosik, linux-sound,
linux-kernel
Done.
On Tue, Sep 10, 2024 at 4:25 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Mon, 09 Sep 2024 04:03:36 +0200,
> Joshua Pius wrote:
> >
> > Yes, this change is for UCM profiles.
> >
> > Yes this should be a one time occurrence as afterwards effort is being
> > made to migrate over to UCM v2.
>
> OK, then I'll take it. But, I noticed that your Signed-off-by tag was
> with google.com address while you submitted from chromium.org.
> Could you align those?
>
>
> thanks,
>
> Takashi
>
> >
> > Thanks,
> >
> > Joshua P
> >
> >
> >
> >
> >
> > On Sun, Sep 8, 2024 at 3:47 AM Takashi Iwai <tiwai@suse.de> wrote:
> > >
> > > On Fri, 06 Sep 2024 23:14:38 +0200,
> > > Joshua Pius wrote:
> > > >
> > > > Specify shortnames for the following Logitech Devices: Rally bar, Rally
> > > > bar mini, Tap, MeetUp and Huddle.
> > > >
> > > > Signed-off-by: Joshua Pius <joshuapius@chromium.org>
> > >
> > > Is this change needed only for UCM profiles? UCM v2 should be able to
> > > handle better to identify models, and such short name updates aren't
> > > needed for them.
> > >
> > > OTOH, I don't mind much to take this kind of small harmless changes
> > > (unless it happens too frequently). So I'll likely take this, but
> > > just for verifying the situation.
> > >
> > >
> > > thanks,
> > >
> > > Takashi
> > >
> > >
> > > > ---
> > > > sound/usb/card.c | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/sound/usb/card.c b/sound/usb/card.c
> > > > index 778de9244f1e..9c411b82a218 100644
> > > > --- a/sound/usb/card.c
> > > > +++ b/sound/usb/card.c
> > > > @@ -384,6 +384,12 @@ static const struct usb_audio_device_name usb_audio_names[] = {
> > > > /* Creative/Toshiba Multimedia Center SB-0500 */
> > > > DEVICE_NAME(0x041e, 0x3048, "Toshiba", "SB-0500"),
> > > >
> > > > + /* Logitech Audio Devices */
> > > > + DEVICE_NAME(0x046d, 0x0867, "Logitech, Inc.", "Logi-MeetUp"),
> > > > + DEVICE_NAME(0x046d, 0x0874, "Logitech, Inc.", "Logi-Tap-Audio"),
> > > > + DEVICE_NAME(0x046d, 0x087c, "Logitech, Inc.", "Logi-Huddle"),
> > > > + DEVICE_NAME(0x046d, 0x0898, "Logitech, Inc.", "Logi-RB-Audio"),
> > > > + DEVICE_NAME(0x046d, 0x08d2, "Logitech, Inc.", "Logi-RBM-Audio"),
> > > > DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"),
> > > >
> > > > DEVICE_NAME(0x05e1, 0x0408, "Syntek", "STK1160"),
> > > > --
> > > > 2.46.0.598.g6f2099f65c-goog
> > > >
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk
2024-09-11 19:27 ` Joshua Pius
@ 2024-09-12 7:23 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2024-09-12 7:23 UTC (permalink / raw)
To: Joshua Pius
Cc: Joshua Pius, alsa-devel, Jaroslav Kysela, Takashi Iwai,
Steven 'Steve' Kendall, Karol Kosik, linux-sound,
linux-kernel
On Wed, 11 Sep 2024 21:27:34 +0200,
Joshua Pius wrote:
>
> Done.
Err, I meant to resubmit a new patch with the consistent From and
Signed-off-by tag. I haven't seen any new patch yet.
Takashi
>
>
> On Tue, Sep 10, 2024 at 4:25 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Mon, 09 Sep 2024 04:03:36 +0200,
> > Joshua Pius wrote:
> > >
> > > Yes, this change is for UCM profiles.
> > >
> > > Yes this should be a one time occurrence as afterwards effort is being
> > > made to migrate over to UCM v2.
> >
> > OK, then I'll take it. But, I noticed that your Signed-off-by tag was
> > with google.com address while you submitted from chromium.org.
> > Could you align those?
> >
> >
> > thanks,
> >
> > Takashi
> >
> > >
> > > Thanks,
> > >
> > > Joshua P
> > >
> > >
> > >
> > >
> > >
> > > On Sun, Sep 8, 2024 at 3:47 AM Takashi Iwai <tiwai@suse.de> wrote:
> > > >
> > > > On Fri, 06 Sep 2024 23:14:38 +0200,
> > > > Joshua Pius wrote:
> > > > >
> > > > > Specify shortnames for the following Logitech Devices: Rally bar, Rally
> > > > > bar mini, Tap, MeetUp and Huddle.
> > > > >
> > > > > Signed-off-by: Joshua Pius <joshuapius@chromium.org>
> > > >
> > > > Is this change needed only for UCM profiles? UCM v2 should be able to
> > > > handle better to identify models, and such short name updates aren't
> > > > needed for them.
> > > >
> > > > OTOH, I don't mind much to take this kind of small harmless changes
> > > > (unless it happens too frequently). So I'll likely take this, but
> > > > just for verifying the situation.
> > > >
> > > >
> > > > thanks,
> > > >
> > > > Takashi
> > > >
> > > >
> > > > > ---
> > > > > sound/usb/card.c | 6 ++++++
> > > > > 1 file changed, 6 insertions(+)
> > > > >
> > > > > diff --git a/sound/usb/card.c b/sound/usb/card.c
> > > > > index 778de9244f1e..9c411b82a218 100644
> > > > > --- a/sound/usb/card.c
> > > > > +++ b/sound/usb/card.c
> > > > > @@ -384,6 +384,12 @@ static const struct usb_audio_device_name usb_audio_names[] = {
> > > > > /* Creative/Toshiba Multimedia Center SB-0500 */
> > > > > DEVICE_NAME(0x041e, 0x3048, "Toshiba", "SB-0500"),
> > > > >
> > > > > + /* Logitech Audio Devices */
> > > > > + DEVICE_NAME(0x046d, 0x0867, "Logitech, Inc.", "Logi-MeetUp"),
> > > > > + DEVICE_NAME(0x046d, 0x0874, "Logitech, Inc.", "Logi-Tap-Audio"),
> > > > > + DEVICE_NAME(0x046d, 0x087c, "Logitech, Inc.", "Logi-Huddle"),
> > > > > + DEVICE_NAME(0x046d, 0x0898, "Logitech, Inc.", "Logi-RB-Audio"),
> > > > > + DEVICE_NAME(0x046d, 0x08d2, "Logitech, Inc.", "Logi-RBM-Audio"),
> > > > > DEVICE_NAME(0x046d, 0x0990, "Logitech, Inc.", "QuickCam Pro 9000"),
> > > > >
> > > > > DEVICE_NAME(0x05e1, 0x0408, "Syntek", "STK1160"),
> > > > > --
> > > > > 2.46.0.598.g6f2099f65c-goog
> > > > >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-09-12 16:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 15:26 [PATCH] ALSA: usb-audio: Add logitech Audio profile quirk Joshua Pius
2024-09-12 16:01 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2024-09-06 21:14 Joshua Pius
2024-09-08 7:48 ` Takashi Iwai
2024-09-09 2:03 ` Joshua Pius
2024-09-10 8:26 ` Takashi Iwai
2024-09-11 19:27 ` Joshua Pius
2024-09-12 7:23 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox