From: Takashi Iwai <tiwai@suse.de>
To: zenghongling <zenghongling@kylinos.cn>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
perex@perex.cz, tiwai@suse.com, zhongling0719@126.com
Subject: Re: [PATCH v2] ALSA: hda/cs8409: Support new Dell Dolphin for device
Date: Mon, 09 Sep 2024 12:03:44 +0200 [thread overview]
Message-ID: <877cblb0u7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240909014457.610682-1-zenghongling@kylinos.cn>
On Mon, 09 Sep 2024 03:44:57 +0200,
zenghongling wrote:
>
> Add 1 new Dell Dolphin Systems, same configuration as older systems.
>
> Signed-off-by: zenghongling <zenghongling@kylinos.cn>
> ---
> sound/pci/hda/patch_cs8409-tables.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_cs8409-tables.c b/sound/pci/hda/patch_cs8409-tables.c
> index 36b411d1..be0cc48 100644
> --- a/sound/pci/hda/patch_cs8409-tables.c
> +++ b/sound/pci/hda/patch_cs8409-tables.c
> @@ -541,6 +541,7 @@ const struct snd_pci_quirk cs8409_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1028, 0x0BBB, "Warlock MLK Dual Mic", CS8409_WARLOCK_MLK_DUAL_MIC),
> SND_PCI_QUIRK(0x1028, 0x0BBC, "Warlock MLK", CS8409_WARLOCK_MLK),
> SND_PCI_QUIRK(0x1028, 0x0BBD, "Warlock MLK Dual Mic", CS8409_WARLOCK_MLK_DUAL_MIC),
> + SND_PCI_QUIRK(0x1028, 0x0BAA, "Dolphin", CS8409_DOLPHIN),
> SND_PCI_QUIRK(0x1028, 0x0BD4, "Dolphin", CS8409_DOLPHIN),
> SND_PCI_QUIRK(0x1028, 0x0BD5, "Dolphin", CS8409_DOLPHIN),
> SND_PCI_QUIRK(0x1028, 0x0BD6, "Dolphin", CS8409_DOLPHIN),
1028:0BAA is already present for ODIN. Conflicting setup?
(And you should try to put the entry at the right position; the table
is sorted in PCI SSID order. If you did that, you should have noticed
the confliction more easily.)
Takashi
prev parent reply other threads:[~2024-09-09 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 1:44 [PATCH v2] ALSA: hda/cs8409: Support new Dell Dolphin for device zenghongling
2024-09-09 10:03 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cblb0u7.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zenghongling@kylinos.cn \
--cc=zhongling0719@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox