From: Thomas Gleixner <tglx@linutronix.de>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] irqdomain: Allow giving name suffix for domain
Date: Thu, 08 Aug 2024 22:17:17 +0200 [thread overview]
Message-ID: <877ccqvkfm.ffs@tglx> (raw)
In-Reply-To: <7a048c0139e79beb46d887b0cd5a620963ff8ef8.1723120028.git.mazziesaccount@gmail.com>
On Thu, Aug 08 2024 at 15:35, Matti Vaittinen wrote:
>
> + if (info->name_suffix)
> + name = bus_token ?
> + kasprintf(GFP_KERNEL, "%pfw-%s-%d", fwnode,
> + info->name_suffix, bus_token) :
> + kasprintf(GFP_KERNEL, "%pfw-%s", fwnode, info->name_suffix);
> + else
> + name = bus_token ?
> + kasprintf(GFP_KERNEL, "%pfw-%d", fwnode, bus_token) :
> + kasprintf(GFP_KERNEL, "%pfw", fwnode);
This really makes my eyes bleed. I know you copied the existing mess,
but that does not make it less tasteless.
I'll send out a cleanup for this horrorshow in a few.
Thanks,
tglx
next prev parent reply other threads:[~2024-08-08 20:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 12:32 [PATCH v2 0/3] regmap IRQ support for devices with multiple IRQs Matti Vaittinen
2024-08-08 12:34 ` [PATCH v2 1/3] irqdomain: simplify simple and legacy domain creation Matti Vaittinen
2024-08-13 10:19 ` Jiaxun Yang
2024-08-13 10:54 ` Matti Vaittinen
2024-08-13 12:02 ` Matti Vaittinen
2024-08-13 12:14 ` Jiaxun Yang
2024-08-13 14:20 ` [tip: irq/core] irqdomain: Always associate interrupts for legacy domains tip-bot2 for Matti Vaittinen
2024-08-20 15:21 ` tip-bot2 for Matti Vaittinen
2024-08-13 12:03 ` [PATCH v2 1/3] irqdomain: simplify simple and legacy domain creation Jiaxun Yang
2024-08-08 12:35 ` [PATCH v2 2/3] irqdomain: Allow giving name suffix for domain Matti Vaittinen
2024-08-08 20:17 ` Thomas Gleixner [this message]
2024-08-08 20:19 ` [PATCH] irqdomain: Cleanup domain name allocation Thomas Gleixner
2024-08-08 20:23 ` [PATCH v2a 2/3] irqdomain: Allow giving name suffix for domain Thomas Gleixner
2024-08-09 5:03 ` Matti Vaittinen
2024-08-09 21:14 ` [tip: irq/core] " tip-bot2 for Matti Vaittinen
2024-08-09 5:19 ` [PATCH] irqdomain: Cleanup domain name allocation Matti Vaittinen
2024-08-09 21:14 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2024-08-08 12:36 ` [PATCH v2 3/3] regmap: Allow setting IRQ domain name suffix Matti Vaittinen
2024-08-09 21:09 ` Thomas Gleixner
2024-08-12 19:05 ` Andy Shevchenko
2024-08-13 9:11 ` Matti Vaittinen
2024-08-14 12:05 ` (subset) [PATCH v2 0/3] regmap IRQ support for devices with multiple IRQs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ccqvkfm.ffs@tglx \
--to=tglx@linutronix.de \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox