public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Lizhe <sensor1010@163.com>, ilpo.jarvinen@linux.intel.com
Cc: linux-kernel@vger.kernel.org, Lizhe <sensor1010@163.com>
Subject: Re: [PATCH] hrtimer.c : Remove redundant thread state settings
Date: Thu, 11 Jan 2024 17:44:20 +0100	[thread overview]
Message-ID: <877ckfkefv.ffs@tglx> (raw)
In-Reply-To: <20240110141349.52718-1-sensor1010@163.com>

On Wed, Jan 10 2024 at 06:13, Lizhe wrote:
> After a thread is awakened, its state is already task_running

That's correct, but please look at hrtimer_wakeup() and the conditional
schedule() invocation in schedule_hrtimeout_range_clock(). You break the
guarantee that this function returns with task state == TASK_RUNNING.

Thanks,

        tglx

  reply	other threads:[~2024-01-11 16:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 14:13 [PATCH] hrtimer.c : Remove redundant thread state settings Lizhe
2024-01-11 16:44 ` Thomas Gleixner [this message]
2024-01-12  5:03   ` lizhe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ckfkefv.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensor1010@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox