public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Leah Neukirchen <leah@vuxu.org>
To: kan.liang@linux.intel.com
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: 'perf top' broken on intel hybrid systems
Date: Sat, 09 Dec 2023 18:14:10 +0100	[thread overview]
Message-ID: <877clnz4bh.fsf@vuxu.org> (raw)
In-Reply-To: <3a8c66ec-537d-4e29-bf08-226dd41b08aa@linux.intel.com>


> The error is because the perf top always tries to open an event on the
> user_requested_cpus, which are all CPUs by default.
> 
> Something as below should fix it. For hybrid, open a PMU event on an
> unsupported CPU should be error out.
> 
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c

This fixes "perf top" on my i7-1355U.  It would be great if you could
get this patch into upstream and stable branches.

Thanks,
-- 
Leah Neukirchen  <leah@vuxu.org>  https://leahneukirchen.org/

  reply	other threads:[~2023-12-09 17:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08 18:57 'perf top' broken on intel hybrid systems Arnaldo Carvalho de Melo
2023-12-08 19:39 ` Liang, Kan
2023-12-09 17:14   ` Leah Neukirchen [this message]
     [not found]     ` <CAP-5=fVKEU1SesA52_jdR1OFAKF6Q6mrXjS+3+cibO6c=Or=6g@mail.gmail.com>
2023-12-11 17:23       ` Ian Rogers
2023-12-11 21:10   ` Arnaldo Carvalho de Melo
2023-12-11 21:25     ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877clnz4bh.fsf@vuxu.org \
    --to=leah@vuxu.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox