From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 297B8C61DF7 for ; Sat, 25 Nov 2023 04:32:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231637AbjKYEcq (ORCPT ); Fri, 24 Nov 2023 23:32:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjKYEcn (ORCPT ); Fri, 24 Nov 2023 23:32:43 -0500 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D932170B for ; Fri, 24 Nov 2023 20:32:49 -0800 (PST) Received: from in02.mta.xmission.com ([166.70.13.52]:56176) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1r6kLR-00HAXs-59; Fri, 24 Nov 2023 21:32:41 -0700 Received: from ip68-227-168-167.om.om.cox.net ([68.227.168.167]:43464 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1r6kLP-00Eszi-T0; Fri, 24 Nov 2023 21:32:40 -0700 From: "Eric W. Biederman" To: Dimitri John Ledkov Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Geert Uytterhoeven , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20231123180246.750674-1-dimitri.ledkov@canonical.com> <87plzzu1w0.fsf@email.froward.int.ebiederm.org> Date: Fri, 24 Nov 2023 22:31:53 -0600 In-Reply-To: (Dimitri John Ledkov's message of "Fri, 24 Nov 2023 18:06:01 +0000") Message-ID: <877cm6tpvq.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1r6kLP-00Eszi-T0;;;mid=<877cm6tpvq.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.168.167;;;frm=ebiederm@xmission.com;;;spf=pass X-XM-AID: U2FsdGVkX1/Ig8I5jQfPGB2EF67P9+pe8TLh/rPUNG8= X-SA-Exim-Connect-IP: 68.227.168.167 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 0/5] remove the last bits of a.out support X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dimitri John Ledkov writes: > On Fri, 24 Nov 2023 at 14:36, Dimitri John Ledkov > wrote: >> >> On Fri, 24 Nov 2023 at 06:01, Eric W. Biederman wrote: >> > >> > Dimitri John Ledkov writes: >> > >> > > I was working on how linux-libc-dev headers are shipped in Ubuntu and >> > > stumbled upon seemingly unused and useless linux/a.out.h header. It >> > > seems like it is an accidental leftover at this point. >> > >> > How do you see that they are unused? > > When I did my code search the only and last remaining userspace code > that imports linux/a.out.h it is the objtool that is patched in these > patch series. > It is also vendored as copy in aboot tool, which has been patched in > many downstreams to use a.out.h instead of linux/a.out.h. It sounds like you have done your homework. Please just document (as you in your reply to me) in your cover letter or elsewhere in the changes so that it is clear that due diligence has been performed and userspace should not break with this change. [snip] > Was your search > https://codesearch.debian.net/search?q=linux%2Fa.out.h&literal=1&perpkg=1 > ? Pretty much. I didn't have the perpkg=1. Debian code search is the most comprehensive code search I am aware of so I took a quick look. Since it appears the only users are vendored versions of linux/a.out.h then it should be possible to make this change without breaking userspace. If it turns that is wrong the changes can be reverted. Eric