From: Thomas Gleixner <tglx@linutronix.de>
To: Wei Gong <gongwei833x@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] genirq: avoid long loops in handle_edge_irq
Date: Fri, 13 Oct 2023 10:44:36 +0200 [thread overview]
Message-ID: <877cnqlxmz.ffs@tglx> (raw)
In-Reply-To: <ZSf3KrAk8fpyNEZr@MacBook-Pro-3.local>
On Thu, Oct 12 2023 at 21:39, Wei Gong wrote:
> O Mon, Oct 09, 2023 at 04:32:10PM +0200, Thomas Gleixner wrote:
>> Now $COND is not true due to the affinity change and the edge handler
>> returns. As a consequence nothing acks the device and no further
>> interrupts are sent by the device.
>>
>> That might not be true for your case, but that's a generic function and the
>> zoo of hardware which uses that is massive.
>>
>> So no, we are not taking a risk here.
>>
>> Thanks,
>>
>> tglx
>>
>>
> By maintaining the original loop exit condition, if a mask mismatch is
> detected within the loop, we will not perform the unmask_irq operation.
> Instead, we will wait until the loop exits before executing unmask_irq.
> Could this approach potentially solve the issue of lost interrupts?
How so exactly?
next prev parent reply other threads:[~2023-10-13 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 10:06 [PATCH v3] genirq: avoid long loops in handle_edge_irq Wei Gong
2023-10-09 14:32 ` Thomas Gleixner
2023-10-12 13:39 ` Wei Gong
2023-10-13 8:44 ` Thomas Gleixner [this message]
2023-10-19 7:02 ` Wei Gong
2023-10-19 8:28 ` Thomas Gleixner
2023-10-19 9:37 ` Wei Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cnqlxmz.ffs@tglx \
--to=tglx@linutronix.de \
--cc=gongwei833x@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox