[PATCH v1] ASoC: dwc: Fix the warnnings about JH7110 ops

[PATCH v1] ASoC: dwc: Fix the warnnings about JH7110 ops

[Xingyu Wu]

Add a check of CONFIG_OF before the JH7110 ops to fix the warnings
that the JH7110 ops are defined but not used when CONFIG_OF is disabled.

Fixes: 1a512d13837a ("Add I2S support for the StarFive JH7110 SoC")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308250433.nhzrhYEo-lkp@intel.com/
Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
---
Hi Mark,

This patch fixes the issue about the warning of JH7110 ops when CONFIG_OF
is disabled. So add a check of CONFIG_OF before defining JH7110 ops.

Thanks,
Xingyu Wu
---
 sound/soc/dwc/dwc-i2s.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index 5ab1b3eb2d28..329015ef1d1e 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -729,6 +729,7 @@ static int dw_configure_dai_by_dt(struct dw_i2s_dev *dev,
 
 }
 
+#ifdef CONFIG_OF
 /* clocks initialization with master mode on JH7110 SoC */
 static int jh7110_i2s_crg_master_init(struct dw_i2s_dev *dev)
 {
@@ -912,6 +913,7 @@ static int jh7110_i2stx0_clk_cfg(struct i2s_clk_config_data *config)
 
 	return clk_set_rate(dev->clk, bclk_rate);
 }
+#endif
 
 static int dw_i2s_probe(struct platform_device *pdev)
 {
-- 
2.25.1

Re: [PATCH v1] ASoC: dwc: Fix the warnnings about JH7110 ops

[Takashi Iwai]

On Tue, 29 Aug 2023 05:36:58 +0200,
Xingyu Wu wrote:
> 
> Add a check of CONFIG_OF before the JH7110 ops to fix the warnings
> that the JH7110 ops are defined but not used when CONFIG_OF is disabled.
> 
> Fixes: 1a512d13837a ("Add I2S support for the StarFive JH7110 SoC")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308250433.nhzrhYEo-lkp@intel.com/
> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
> ---
> Hi Mark,
> 
> This patch fixes the issue about the warning of JH7110 ops when CONFIG_OF
> is disabled. So add a check of CONFIG_OF before defining JH7110 ops.
> 
> Thanks,
> Xingyu Wu

The very same fix went already in my sound.git tree, commit
8d2a0cdf5229.


thanks,

Takashi

Re: [PATCH v1] ASoC: dwc: Fix the warnnings about JH7110 ops

[Xingyu Wu]

On 2023/8/29 14:40, Takashi Iwai wrote:
> On Tue, 29 Aug 2023 05:36:58 +0200,
> Xingyu Wu wrote:
>> 
>> Add a check of CONFIG_OF before the JH7110 ops to fix the warnings
>> that the JH7110 ops are defined but not used when CONFIG_OF is disabled.
>> 
>> Fixes: 1a512d13837a ("Add I2S support for the StarFive JH7110 SoC")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202308250433.nhzrhYEo-lkp@intel.com/
>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>> ---
>> Hi Mark,
>> 
>> This patch fixes the issue about the warning of JH7110 ops when CONFIG_OF
>> is disabled. So add a check of CONFIG_OF before defining JH7110 ops.
>> 
>> Thanks,
>> Xingyu Wu
> 
> The very same fix went already in my sound.git tree, commit
> 8d2a0cdf5229.
> 
> 
> thanks,
> 
> Takashi

Great, please ignore this patch.

Thanks,
Xingyu Wu