From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD25C7EE2E for ; Tue, 13 Jun 2023 07:36:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240334AbjFMHgp (ORCPT ); Tue, 13 Jun 2023 03:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240276AbjFMHgm (ORCPT ); Tue, 13 Jun 2023 03:36:42 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC4611709 for ; Tue, 13 Jun 2023 00:36:37 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5981E21F89; Tue, 13 Jun 2023 07:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686641796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fARwb/FOWC2J0IiNmo1ULMamrop8hmzZFfpzdyoCU/w=; b=t6M9c4a9ynt2QnblBDTEeXcbL5TbH+GJaFmhsxIVUIXmfDOlDnJ7Q/BK9eU+j6Klpr+7nw csDs23DWMVBjkP2q0HriN8VjMonS4SY/lGRzjpWn4uv2fLmy7PXIuIGUkQXpQgFX/1fpVS U2aPyyvBnK0GzepwuydyZH62QPL7vKc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686641796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fARwb/FOWC2J0IiNmo1ULMamrop8hmzZFfpzdyoCU/w=; b=Hg56atq0EVLED9Hh+7DNyJdiD+EQGbDEx3vKkZTa8dxznXxZ5AKI7x1NsqQReFeMA0Xd1/ 8vQemszzlpj/uIBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B7A713345; Tue, 13 Jun 2023 07:36:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hdzECYQciGQ7GAAAMHmgww (envelope-from ); Tue, 13 Jun 2023 07:36:36 +0000 Date: Tue, 13 Jun 2023 09:36:34 +0200 Message-ID: <877cs7g6f1.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda: Use maple tree register cache In-Reply-To: <87v8fua1qm.wl-tiwai@suse.de> References: <20230609-alsa-hda-maple-v1-1-a2b725c8b8f5@kernel.org> <87v8fua1qm.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Jun 2023 09:37:21 +0200, Takashi Iwai wrote: > > On Sat, 10 Jun 2023 16:26:37 +0200, > Mark Brown wrote: > > > > HDA can only support single register read and write operations so does not > > benefit from block writes. This means it gets no benefit from using the > > rbtree register cache over the maple tree register cache so convert it to > > use maple trees instead, it is more modern. > > > > Signed-off-by: Mark Brown > > Thanks, applied to for-next branch. Now I noticed errors like snd_hda_codec_realtek hdaudioC0D0: Unable to sync register 0x2f0009. -5 and it turned out that the error comes from this patch. This is an error from regache_sync_val(), and it indicates that the synced register is write-only; regcache_maple_sync() tries to sync all cached values no matter whether it's writable or not, then hitting this. I'll submit a fix patch. thanks, Takashi