From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06633C77B7A for ; Tue, 6 Jun 2023 15:46:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235864AbjFFPqF (ORCPT ); Tue, 6 Jun 2023 11:46:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236713AbjFFPp5 (ORCPT ); Tue, 6 Jun 2023 11:45:57 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B661110F9 for ; Tue, 6 Jun 2023 08:45:49 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 470E0219EB; Tue, 6 Jun 2023 15:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686066348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zIRZuOqdc1wbgXJlnttVCJmlBEYYHdfUu9cmmFB8VxI=; b=MLYden4PysPezLPwrVom0z5h5s95w2GwZow9JKezerxq2xCF7YQMZPeqFUAi+KVCizPfc2 hZwhajDMwcbvl4NjtmuFaPmJCxOu73+5Vj1SA50ECcPISp3DHfkI3oSGOQE0zMK5VmUrTn RZ4MD2roba8ViLEiKxjUaLuSeoVhHLQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686066348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zIRZuOqdc1wbgXJlnttVCJmlBEYYHdfUu9cmmFB8VxI=; b=ULrI3S/cmX13oY3UQO9BrjqTNsERUYy1MVZRjyqCIv68tBuQqOtw+WTqDUu36RxKtqu8w3 M4kWjrbq1vmbK/Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1FDA313776; Tue, 6 Jun 2023 15:45:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yprpBqxUf2TmJwAAMHmgww (envelope-from ); Tue, 06 Jun 2023 15:45:48 +0000 Date: Tue, 06 Jun 2023 17:45:47 +0200 Message-ID: <877csgfvbo.wl-tiwai@suse.de> From: Takashi Iwai To: Chris Chiu Cc: perex@perex.cz, tiwai@suse.com, sbinding@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Enable 4 amplifiers instead of 2 on a HP platform In-Reply-To: <20230606145747.135966-1-chris.chiu@canonical.com> References: <20230606145747.135966-1-chris.chiu@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Jun 2023 16:57:47 +0200, Chris Chiu wrote: > > In the commit 7bb62340951a ("ALSA: hda/realtek: fix speaker, mute/micmute > LEDs not work on a HP platform"), speakers and LEDs are fixed but only 2 > CS35L41 amplifiers on SPI bus connected to Realtek codec are enabled. Need > the ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED to get all amplifiers working. > > Signed-off-by: Chris Chiu Applied now with the manual addition of Fixes tag. At the next time, please don't forget to put the proper Fixes tag if you know the commit to fix. thanks, Takashi