From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70783C7EE2C for ; Mon, 5 Jun 2023 13:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233453AbjFENnJ (ORCPT ); Mon, 5 Jun 2023 09:43:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjFENnH (ORCPT ); Mon, 5 Jun 2023 09:43:07 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34B0F9C; Mon, 5 Jun 2023 06:43:06 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E97081FE6E; Mon, 5 Jun 2023 13:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685972584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DRKm7O+HgSR55AAbKOdib+1LRmlh1hA+3NtduQerOLY=; b=cnVfBFXi3YM+Wa8DaRZ/TueqMy/AyaY3F/LyYpenA+7DNR+uoymrc4MMOWLxi8uMW4K6Uc mg0yFYZ9rJkxX4rcKN2VGbq1OvoGJCPJizBZn1BMNKO/8koLRrH3KRTRij7mUPEL+JgQkz v52Yi5vjUkGTiiTGAnaRXiVOLGYn5Eo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685972584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DRKm7O+HgSR55AAbKOdib+1LRmlh1hA+3NtduQerOLY=; b=1Zqw9BAUK3ZkaB5twVNZYJbYm8BBBW79E71nAr885te/h73lKAIqq39ZBrduWtNp/yLEAI vDiO03NqB/ol1hDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B4A4F139C7; Mon, 5 Jun 2023 13:43:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id D7EgK2jmfWQnOwAAMHmgww (envelope-from ); Mon, 05 Jun 2023 13:43:04 +0000 Date: Mon, 05 Jun 2023 15:43:04 +0200 Message-ID: <877csihvo7.wl-tiwai@suse.de> From: Takashi Iwai To: Joakim Tjernlund Cc: "stable@vger.kernel.org" , "gregkh@linuxfoundation.org" , "perex@perex.cz" , "michael@ralston.id.au" , "linux-kernel@vger.kernel.org" , "tiwai@suse.com" , "alsa-devel@alsa-project.org" Subject: Re: [PATCH] ALSA: usb-audio: Fix "cannot set freq 48000 to ep 0x3" msgs In-Reply-To: <892df5be364e29f776ac8db2dd9e928de5a2f2a4.camel@infinera.com> References: <20230601131116.1014250-1-joakim.tjernlund@infinera.com> <202bbbc0f51522e8545783c4c5577d12a8e2d56d.camel@infinera.com> <87pm6aicin.wl-tiwai@suse.de> <892df5be364e29f776ac8db2dd9e928de5a2f2a4.camel@infinera.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 05 Jun 2023 15:21:51 +0200, Joakim Tjernlund wrote: > > On Mon, 2023-06-05 at 09:39 +0200, Takashi Iwai wrote: > > On Thu, 01 Jun 2023 16:28:05 +0200, > > Joakim Tjernlund wrote: > > > > > > Adding Michael Ralston > > > > > > He did have problems with his behringer UMC404HD device when this whole seq. was removed. > > > Ralston, can you try if the below change affects your device? > > > > Sorry for the late reaction, as I've been off in the last weeks. > > NP. > > > > > The code sequence there seems pretty sensitive, and swapping or > > dropping the call might break things easily on certain devices, > > unfortunately. So, I guess we can't take the patch as is. If any, we > > need to fiddle the call order depending on the device quirk or such. > > I guess we may try to fit with the existing quirk flag. Let me check > > it later. > > yes, this is tricky. To me it look like this code will always set 48000 sample rate and > not all devices support that on all EPs. > Maybe one can get away with not setting sample rate at all? Just guessing though. I guess it should work without setting the rate explicitly, but as already mentioned, some devices (firmware) might need it. Who knows. The vendors apparently test only with Windows and/or MacOS, and issuing unexpected commands (or missing the expected command) can screw up firmware... Takashi > > Jocke > > > > > > > thanks, > > > > Takashi > > > > > > > Jocke > > > > > > On Thu, 2023-06-01 at 15:11 +0200, Joakim Tjernlund wrote: > > > > On some USB speaker devices(Jabra/Logitech) we see above error > > > > msg when connecting device to computer and kernel is probing the device. > > > > > > > > Moving the snd_usb_init_sample_rate() to after usb_set_interface() makes > > > > the error go away. > > > > > > > > Signed-off-by: Joakim Tjernlund > > > > Cc: stable@vger.kernel.org > > > > --- > > > > sound/usb/stream.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/sound/usb/stream.c b/sound/usb/stream.c > > > > index f10f4e6d3fb8..d9ac8663a48b 100644 > > > > --- a/sound/usb/stream.c > > > > +++ b/sound/usb/stream.c > > > > @@ -1226,8 +1226,8 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, > > > > /* try to set the interface... */ > > > > usb_set_interface(chip->dev, iface_no, 0); > > > > snd_usb_init_pitch(chip, fp); > > > > - snd_usb_init_sample_rate(chip, fp, fp->rate_max); > > > > usb_set_interface(chip->dev, iface_no, altno); > > > > + snd_usb_init_sample_rate(chip, fp, fp->rate_max); > > > > } > > > > return 0; > > > > } > > > >