From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF163C7EE33 for ; Wed, 24 May 2023 08:10:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239982AbjEXIKx (ORCPT ); Wed, 24 May 2023 04:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbjEXIKv (ORCPT ); Wed, 24 May 2023 04:10:51 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA9BDA1; Wed, 24 May 2023 01:10:49 -0700 (PDT) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684915848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oDNsNlWRYKgt782T3/Agu9IJLsTFRckuzBM5WP6JWeY=; b=08ZKCoEmx575FSIoTYamJgNW8rePnBVnnUl6NvnxaHXFWU6Rq224/aupOg/eEc4vuc4MfQ MH4PTQrb+f1zmJHllRcVdq+SI0dxpy/Kg6w1jrEXpX1EmpZjjpfo46v2QNQKk08bOcGP0o vpcOnSSgXeNhk3BtvXOh3hYUo3217cnemU1FZEHbLOa0Tx/TUHuxCC0joPcDxX6sbD5Ubq /FLwZbEDF1qBFLkXxuwtgKrcEVC/5mBI22AhFxc50qla3SfCyZHQMGzRxFxOU+CCHC3WyR WijQa6rJJYvCYOgU3Xaq77sNcWZkJbb3+slB2DaDzZ0mPGekEuhomUFOiQML/A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684915848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oDNsNlWRYKgt782T3/Agu9IJLsTFRckuzBM5WP6JWeY=; b=lAhXoMdbrS11A26A40eqmMgwoW8fQdExtcMd2/P417ochMP88Os923k/4UfR12W1tS7eSv W04A72RRvpeyo3AQ== To: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes Cc: Jonathan Corbet , phone-devel@vger.kernel.org, linux-doc@vger.kernel.org, Luca Weiss , linux-kernel@vger.kernel.org, Petr Mladek Subject: Re: [PATCH] vsprintf/doc: Document format flags including field width and precision In-Reply-To: <20230522150853.30417-1-pmladek@suse.com> References: <20230522150853.30417-1-pmladek@suse.com> Date: Wed, 24 May 2023 10:14:20 +0206 Message-ID: <877csyjgnf.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-05-22, Petr Mladek wrote: > +Examples:: > + printk("Dynamic table: |%*d|%*s|\n", id_width, id, max_name_len, name); > + printk("Dynamic precision: %.*f\n", precision, value); Generally speaking, it is rare to use printk() without a loglevel specified. And it is preferred that the pr_ or dev_ macros are used. Perhaps the examples should call pr_info() instead? John Ogness