Re: [PATCH v4 4/6] riscv: Fix EFI stub usage of KASAN instrumented strcmp function

Atish Patra
2023-02-03T07:59:14Z

On Thu, Feb 2, 2023 at 11:56 PM Alexandre Ghiti <alexghiti@rivosinc.com> wrote:
>
> The EFI stub must not use any KASAN instrumented code as the kernel
> proper did not initialize the thread pointer and the mapping for the
> KASAN shadow region.
>
> Avoid using the generic strcmp function, instead use the one in
> drivers/firmware/efi/libstub/string.c.
>
> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/riscv/kernel/image-vars.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/image-vars.h b/arch/riscv/kernel/image-vars.h
> index 7e2962ef73f9..15616155008c 100644
> --- a/arch/riscv/kernel/image-vars.h
> +++ b/arch/riscv/kernel/image-vars.h
> @@ -23,8 +23,6 @@
> * linked at. The routines below are all implemented in assembler in a
> * position independent manner
> */
> -__efistub_strcmp = strcmp;
> -
> __efistub__start = _start;
> __efistub__start_kernel = _start_kernel;
> __efistub__end = _end;
> --
> 2.37.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

Reviewed-by: Atish Patra <atishp@rivosinc.com>

--
Regards,
Atish