RE: [PATCH v3 1/4] wifi: brcmfmac: Rename Cypress 89459 to BCM4355

Ping-Ke Shih
2023-02-13T00:33:21Z

> -----Original Message-----
> From: Hector Martin <marcan@marcan.st>
> Sent: Saturday, February 11, 2023 6:09 PM
> To: Ping-Ke Shih <pkshih@realtek.com>; Arend van Spriel <aspriel@gmail.com>; Franky Lin
> <franky.lin@broadcom.com>; Hante Meuleman <hante.meuleman@broadcom.com>; Kalle Valo <kvalo@kernel.org>;
> David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Cc: Alexander Prutskov <alep@cypress.com>; Chi-Hsien Lin <chi-hsien.lin@cypress.com>; Wright Feng
> <wright.feng@cypress.com>; Ian Lin <ian.lin@infineon.com>; Soontak Lee <soontak.lee@cypress.com>; Joseph
> chuang <jiac@cypress.com>; Sven Peter <sven@svenpeter.dev>; Alyssa Rosenzweig <alyssa@rosenzweig.io>;
> Aditya Garg <gargaditya08@live.com>; Jonas Gorski <jonas.gorski@gmail.com>; asahi@lists.linux.dev;
> linux-wireless@vger.kernel.org; brcm80211-dev-list.pdl@broadcom.com; SHA-cyfmac-dev-list@infineon.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Arend van Spriel <arend.vanspriel@broadcom.com>
> Subject: Re: [PATCH v3 1/4] wifi: brcmfmac: Rename Cypress 89459 to BCM4355
>
> On 10/02/2023 12.42, Ping-Ke Shih wrote:
> >
> >
> >> -----Original Message-----
> >> From: Hector Martin <marcan@marcan.st>
> >> Sent: Friday, February 10, 2023 10:50 AM
> >> To: Arend van Spriel <aspriel@gmail.com>; Franky Lin <franky.lin@broadcom.com>; Hante Meuleman
> >> <hante.meuleman@broadcom.com>; Kalle Valo <kvalo@kernel.org>; David S. Miller <davem@davemloft.net>;
> Eric
> >> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> >> Cc: Alexander Prutskov <alep@cypress.com>; Chi-Hsien Lin <chi-hsien.lin@cypress.com>; Wright Feng
> >> <wright.feng@cypress.com>; Ian Lin <ian.lin@infineon.com>; Soontak Lee <soontak.lee@cypress.com>;
> Joseph
> >> chuang <jiac@cypress.com>; Sven Peter <sven@svenpeter.dev>; Alyssa Rosenzweig <alyssa@rosenzweig.io>;
> >> Aditya Garg <gargaditya08@live.com>; Jonas Gorski <jonas.gorski@gmail.com>; asahi@lists.linux.dev;
> >> linux-wireless@vger.kernel.org; brcm80211-dev-list.pdl@broadcom.com;
> SHA-cyfmac-dev-list@infineon.com;
> >> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Hector Martin <marcan@marcan.st>; Arend van
> Spriel
> >> <arend.vanspriel@broadcom.com>
> >> Subject: [PATCH v3 1/4] wifi: brcmfmac: Rename Cypress 89459 to BCM4355
> >>
> >> The commit that introduced support for this chip incorrectly claimed it
> >> is a Cypress-specific part, while in actuality it is just a variant of
> >> BCM4355 silicon (as evidenced by the chip ID).
> >>
> >> The relationship between Cypress products and Broadcom products isn't
> >> entirely clear but given what little information is available and prior
> >> art in the driver, it seems the convention should be that originally
> >> Broadcom parts should retain the Broadcom name.
> >>
> >> Thus, rename the relevant constants and firmware file. Also rename the
> >> specific 89459 PCIe ID to BCM43596, which seems to be the original
> >> subvariant name for this PCI ID (as defined in the out-of-tree bcmdhd
> >> driver).
> >>
> >> v2: Since Cypress added this part and will presumably be providing
> >> its supported firmware, we keep the CYW designation for this device.
> >>
> >> v3: Drop the RAW device ID in this commit. We don't do this for the
> >> other chips since apparently some devices with them exist in the wild,
> >> but there is already a 4355 entry with the Broadcom subvendor and WCC
> >> firmware vendor, so adding a generic fallback to Cypress seems
> >> redundant (no reason why a device would have the raw device ID *and* an
> >> explicitly programmed subvendor).
> >
> > Do you really want to add changes of v2 and v3 to commit message? Or,
> > just want to let reviewers know that? If latter one is what you want,
> > move them after s-o-b with delimiter ---
>
> Both; I thought those things were worth mentioning in the commit message
> as it stands on its own, and left the version tags in so reviewers know
> when they were introduced.
>

With this reply, it is clear that you did those intentionally, not forgot
something, so things are clear to me. The further discussion in different
aspects of view in thread are also helpful for me to get much.

Ping-Ke