Re: [PATCH 07/15] dt-bindings: clock: Add Ambarella clock bindings

Li Chen
2023-01-28T10:11:22Z

Hi Krzysztof,

---- On Sat, 28 Jan 2023 18:08:00 +0800 Krzysztof Kozlowski wrote ---
> On 28/01/2023 10:42, Li Chen wrote:
> > Got it, I will model it as:
> >
> > rct_syscon(compatible include "ambarella, -clock"...)
> > | peripheral A
> > | peripheral B
> > | ...
> >
> >
> > One more question, two driver models:
> > a. compatible = "ambarella, -clock", handle all clocks(pll, div, mux, composite) in single driver.
> > b. compatible = "ambarella, -pll-clock", "ambarella, -composite-clock", "ambarella, -div-clock"......
> > and implement a driver for each of them.
> >
> > Which driver model is preferred?
>
> We do not talk here at all about drivers. This is independent and not
> really related.
>
> Anyway, independent features mostly have separate drivers. Each separate
> driver should be located in respective subsystem. But again - we do not
> talk here about drivers at all, so please do not bring them into the
> problem. It will make everything more complicated...

Ok, that makes sense. Sorry about that.

Regards,
Li