From: Thomas Gleixner <tglx@linutronix.de>
To: Duoming Zhou <duoming@zju.edu.cn>, linux-kernel@vger.kernel.org
Cc: jstultz@google.com, sboyd@kernel.org, edumazet@google.com,
Duoming Zhou <duoming@zju.edu.cn>
Subject: Re: [PATCH] timers: fix synchronization rules in comments of del_timer_sync
Date: Mon, 08 Aug 2022 16:01:57 +0200 [thread overview]
Message-ID: <877d3irfze.ffs@tglx> (raw)
In-Reply-To: <20220701085535.17018-1-duoming@zju.edu.cn>
On Fri, Jul 01 2022 at 16:55, Duoming Zhou wrote:
> - * Synchronization rules: Callers must prevent restarting of the timer,
> - * otherwise this function is meaningless. It must not be called from
> - * interrupt contexts unless the timer is an irqsafe one. The caller must
> - * not hold locks which would prevent completion of the timer's
> - * handler. The timer's handler must not call add_timer_on(). Upon exit the
> - * timer is not queued and the handler is not running on any CPU.
> + * Synchronization rules: Callers must prevent restarting of the timer in
> + * other places except for the timer's handler, otherwise this function is
> + * meaningless. It must not be called from interrupt contexts unless the
> + * timer is an irqsafe one. The caller must not hold locks which would
> + * prevent completion of the timer's handler. The timer's handler must
> + * not call add_timer_on().
If we are making this correct: What's so special about add_timer_on()?
Thanks,
tglx
next prev parent reply other threads:[~2022-08-08 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 8:55 [PATCH] timers: fix synchronization rules in comments of del_timer_sync Duoming Zhou
2022-07-02 1:47 ` duoming
2022-08-08 14:01 ` Thomas Gleixner [this message]
2022-08-09 1:02 ` duoming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d3irfze.ffs@tglx \
--to=tglx@linutronix.de \
--cc=duoming@zju.edu.cn \
--cc=edumazet@google.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox