From: Kalle Valo <kvalo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paolo Abeni <pabeni@redhat.com>,
Veerendranath Jakkam <quic_vjakkam@quicinc.com>,
kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Arend van Spriel <aspriel@gmail.com>
Subject: Re: [GIT PULL] Networking for 6.0
Date: Fri, 05 Aug 2022 17:22:02 +0300 [thread overview]
Message-ID: <877d3mixdh.fsf@kernel.org> (raw)
In-Reply-To: <87les4id7b.fsf@kernel.org> (Kalle Valo's message of "Thu, 04 Aug 2022 12:13:12 +0300")
Kalle Valo <kvalo@kernel.org> writes:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
>> Hmm. Another issue with the networking pull..
>>
>> On Wed, Aug 3, 2022 at 3:15 AM Paolo Abeni <pabeni@redhat.com> wrote:
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-6.0
>>>
>>> Veerendranath Jakkam (5):
>>> cfg80211: Indicate MLO connection info in connect and roam callbacks
>>
>> This one added a
>>
>> for_each_valid_link(cr, link) {
>> if (WARN_ON_ONCE(!cr->links[link].bss))
>> break;
>> }
>>
>> in net/wireless/sme.c, and it seems to trigger on my brand new M2 Macbook Air.
>>
>> Wireless still works fine (I'm writing this report on the machine),
>> but you get a scary splat:
>>
>> WARNING: CPU: 5 PID: 514 at net/wireless/sme.c:786
>> __cfg80211_connect_result+0x2fc/0x5c0 [cfg80211]
>>
>> full call trace etc in the attachment.
>
> Thanks for the report, adding also Arend and changing Johannes' email.
> Unfortunately Johannes is away this week. Arend, would you be able to
> look at this? I don't have any brcmfmac hardware.
Veerendranath took a look at this and here's a quick fix:
https://patchwork.kernel.org/project/linux-wireless/patch/20220805135259.4126630-1-quic_vjakkam@quicinc.com/
Do note that this isn't tested with brcmfmac but it should work :)
Linus, do you want to take that directly or should I take it to wireless
tree? I assume with the latter you would then get it by the end of next
week.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-08-05 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 10:14 [GIT PULL] Networking for 6.0 Paolo Abeni
2022-08-03 23:35 ` Linus Torvalds
2022-08-04 9:43 ` Drewek, Wojciech
2022-08-03 23:50 ` pr-tracker-bot
2022-08-03 23:52 ` Linus Torvalds
2022-08-04 0:11 ` Pablo Neira Ayuso
2022-08-04 0:27 ` Linus Torvalds
2022-08-04 0:39 ` Pablo Neira Ayuso
2022-08-04 4:17 ` Linus Torvalds
2022-08-04 9:13 ` Kalle Valo
2022-08-05 14:22 ` Kalle Valo [this message]
2022-08-05 16:34 ` Linus Torvalds
2022-08-08 8:14 ` Kalle Valo
2022-08-08 18:33 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d3mixdh.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=aspriel@gmail.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_vjakkam@quicinc.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).