Re: [PATCH 2/5] Input: mtk-pmic-keys - Use regmap_{set,clear}_bits where possible

Mattijs Korpershoek
2022-05-20T15:38:48Z

On ven., mai 20, 2022 at 14:51, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote:

> Instead of always using regmap_update_bits(), let's go for the shorter
> regmap_set_bits() and regmap_clear_bits() where possible.
>
> No functional change.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> drivers/input/keyboard/mtk-pmic-keys.c | 24 ++++++------------------
> 1 file changed, 6 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
> index 8e4fa7cd16e6..83d0b90cc8cb 100644
> --- a/drivers/input/keyboard/mtk-pmic-keys.c
> +++ b/drivers/input/keyboard/mtk-pmic-keys.c
> @@ -157,28 +157,16 @@ static void mtk_pmic_keys_lp_reset_setup(struct mtk_pmic_keys *keys,
>
> switch (long_press_mode) {
> case LP_ONEKEY:
> - regmap_update_bits(keys->regmap, pmic_rst_reg,
> - MTK_PMIC_PWRKEY_RST,
> - MTK_PMIC_PWRKEY_RST);
> - regmap_update_bits(keys->regmap, pmic_rst_reg,
> - MTK_PMIC_HOMEKEY_RST,
> - 0);
> + regmap_set_bits(keys->regmap, pmic_rst_reg, MTK_PMIC_PWRKEY_RST);
> + regmap_clear_bits(keys->regmap, pmic_rst_reg, MTK_PMIC_HOMEKEY_RST);
> break;
> case LP_TWOKEY:
> - regmap_update_bits(keys->regmap, pmic_rst_reg,
> - MTK_PMIC_PWRKEY_RST,
> - MTK_PMIC_PWRKEY_RST);
> - regmap_update_bits(keys->regmap, pmic_rst_reg,
> - MTK_PMIC_HOMEKEY_RST,
> - MTK_PMIC_HOMEKEY_RST);
> + regmap_set_bits(keys->regmap, pmic_rst_reg, MTK_PMIC_PWRKEY_RST);
> + regmap_set_bits(keys->regmap, pmic_rst_reg, MTK_PMIC_HOMEKEY_RST);
> break;
> case LP_DISABLE:
> - regmap_update_bits(keys->regmap, pmic_rst_reg,
> - MTK_PMIC_PWRKEY_RST,
> - 0);
> - regmap_update_bits(keys->regmap, pmic_rst_reg,
> - MTK_PMIC_HOMEKEY_RST,
> - 0);
> + regmap_clear_bits(keys->regmap, pmic_rst_reg, MTK_PMIC_PWRKEY_RST);
> + regmap_clear_bits(keys->regmap, pmic_rst_reg, MTK_PMIC_HOMEKEY_RST);
> break;
> default:
> break;
> --
> 2.35.1