From: Thomas Gleixner <tglx@linutronix.de>
To: Paolo Bonzini <bonzini@gnu.org>, dave.hansen@linux.intel.com
Cc: yang.zhong@intel.com, ravi.v.shankar@intel.com, mingo@redhat.com,
"Chang S. Bae" <chang.seok.bae@intel.com>,
bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org,
KVM list <kvm@vger.kernel.org>
Subject: Re: ping Re: [PATCH v4 0/2] x86: Fix ARCH_REQ_XCOMP_PERM and update the test
Date: Wed, 23 Mar 2022 13:55:11 +0100 [thread overview]
Message-ID: <877d8kakwg.ffs@tglx> (raw)
In-Reply-To: <87a6dgam7b.ffs@tglx>
On Wed, Mar 23 2022 at 13:27, Thomas Gleixner wrote:
> On Wed, Mar 23 2022 at 12:04, Paolo Bonzini wrote:
>> can this series be included in 5.18 and CCed to stable?
>
> working on it. There is another issue with that which I'm currently
> looking into.
The size calculation for the kernel state fails to take supervisor
states into account. Up to 5.18 that did not matter because ENQCMD/PASID
was disabled. But now it matters...
Thanks,
tglx
---
--- a/arch/x86/kernel/fpu/xstate.c
+++ b/arch/x86/kernel/fpu/xstate.c
@@ -1625,6 +1625,8 @@ static int __xstate_request_perm(u64 per
/* Calculate the resulting kernel state size */
mask = permitted | requested;
+ /* Take supervisor states into account */
+ mask |= xfeatures_mask_supervisor();
ksize = xstate_calculate_size(mask, compacted);
/* Calculate the resulting user state size */
next prev parent reply other threads:[~2022-03-23 12:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 17:36 [PATCH v4 0/2] x86: Fix ARCH_REQ_XCOMP_PERM and update the test Chang S. Bae
2022-01-29 17:36 ` [PATCH v4 1/2] x86/arch_prctl: Fix the ARCH_REQ_XCOMP_PERM implementation Chang S. Bae
2022-03-07 12:20 ` Hao Xiang
2022-03-07 18:53 ` Chang S. Bae
2022-03-08 8:36 ` Hao Xiang
2022-03-23 23:31 ` [tip: x86/urgent] x86/fpu/xstate: " tip-bot2 for Yang Zhong
2022-01-29 17:36 ` [PATCH v4 2/2] selftests/x86/amx: Update the ARCH_REQ_XCOMP_PERM test Chang S. Bae
2022-03-23 16:44 ` Thomas Gleixner
2022-03-23 21:27 ` Chang S. Bae
2022-03-23 23:31 ` [tip: x86/urgent] " tip-bot2 for Chang S. Bae
2022-03-23 11:04 ` ping Re: [PATCH v4 0/2] x86: Fix ARCH_REQ_XCOMP_PERM and update the test Paolo Bonzini
2022-03-23 12:27 ` Thomas Gleixner
2022-03-23 12:55 ` Thomas Gleixner [this message]
2022-03-23 14:24 ` Paolo Bonzini
2022-03-23 17:07 ` Thomas Gleixner
2022-03-23 17:20 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d8kakwg.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bonzini@gnu.org \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=x86@kernel.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox