public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	peterz@infradead.org, Stefano Garzarella <sgarzare@redhat.com>,
	Keir Fraser <keirf@google.com>
Subject: Re: [PATCH 2/2] Revert "virtio_pci: harden MSI-X interrupts"
Date: Wed, 23 Mar 2022 09:05:38 +0000	[thread overview]
Message-ID: <877d8lxcm5.wl-maz@kernel.org> (raw)
In-Reply-To: <20220323031524.6555-2-jasowang@redhat.com>

On Wed, 23 Mar 2022 03:15:24 +0000,
Jason Wang <jasowang@redhat.com> wrote:
> 
> This reverts commit 9e35276a5344f74d4a3600fc4100b3dd251d5c56. Issue
> were reported for the drivers that are using affinity managed IRQ
> where manually toggling IRQ status is not expected. And we forget to
> enable the interrupts in the restore path as well.
> 
> In the future, we will rework on the interrupt hardening.
> 
> Fixes: 9e35276a5344 ("virtio_pci: harden MSI-X interrupts")
> Reported-by: Marc Zyngier <maz@kernel.org>
> Reported-by: Stefano Garzarella <sgarzare@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>

For this patch and the INTx one:

Acked-by: Marc Zyngier <maz@kernel.org>

Please keep me in the loop when you decide to rework this.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

      parent reply	other threads:[~2022-03-23  9:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23  3:15 [PATCH 1/2] Revert "virtio-pci: harden INTX interrupts" Jason Wang
2022-03-23  3:15 ` [PATCH 2/2] Revert "virtio_pci: harden MSI-X interrupts" Jason Wang
2022-03-23  9:03   ` Marc Zyngier
2022-03-23  9:21     ` Jason Wang
2022-03-23  9:05   ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d8lxcm5.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=jasowang@redhat.com \
    --cc=keirf@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sgarzare@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox