From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBCA5C433F5 for ; Mon, 8 Nov 2021 19:19:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5933610CB for ; Mon, 8 Nov 2021 19:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236925AbhKHTVw (ORCPT ); Mon, 8 Nov 2021 14:21:52 -0500 Received: from out03.mta.xmission.com ([166.70.13.233]:47940 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236872AbhKHTVv (ORCPT ); Mon, 8 Nov 2021 14:21:51 -0500 Received: from in02.mta.xmission.com ([166.70.13.52]:43664) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mkAAb-00E1Hk-GA; Mon, 08 Nov 2021 12:19:05 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:59808 helo=email.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mkAAZ-002ABU-G3; Mon, 08 Nov 2021 12:19:04 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Nathan Chancellor Cc: Santosh Shilimkar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann References: <20211102160315.1067553-1-nathan@kernel.org> Date: Mon, 08 Nov 2021 13:18:41 -0600 In-Reply-To: <20211102160315.1067553-1-nathan@kernel.org> (Nathan Chancellor's message of "Tue, 2 Nov 2021 09:03:15 -0700") Message-ID: <877ddipib2.fsf@disp2133> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1mkAAZ-002ABU-G3;;;mid=<877ddipib2.fsf@disp2133>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+r9bFhQzEzvlEH5/zaHOV1889fUy/lLVc= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread() X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nathan Chancellor writes: > This function should not return a value: > > drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread': > drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type] > 429 | return 0; > | ^ > drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here > 416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors Apologies for not replying to this sooner. I did not realize at first that this was in response to one of my changes. Arnd also reported this and included a correct fix please see: https://lkml.kernel.org/r/20211105075119.2327190-1-arnd@kernel.org Thank you, Eric > > Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit") > Signed-off-by: Nathan Chancellor > --- > drivers/soc/ti/wkup_m3_ipc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c > index 0733443a2631..2238beb40f8d 100644 > --- a/drivers/soc/ti/wkup_m3_ipc.c > +++ b/drivers/soc/ti/wkup_m3_ipc.c > @@ -425,8 +425,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) > dev_err(dev, "rproc_boot failed\n"); > else > m3_ipc_state = m3_ipc; > - > - return 0; > } > > static int wkup_m3_ipc_probe(struct platform_device *pdev) > > base-commit: ac4fdfaf4792d41ad7b24d1c8ab486aeb7ccd495