* [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations,
@ 2021-10-12 13:33 Thomas Gleixner
2021-10-12 14:25 ` [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations Juergen Gross
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2021-10-12 13:33 UTC (permalink / raw)
To: LKML; +Cc: x86, Juergen Gross, Stefano Stabellini, Boris Ostrovsky,
xen-devel
All these handlers are regular device interrupt handlers, so they already
went through the proper entry code which handles this correctly.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: x86@kernel.org
Cc: xen-devel@lists.xenproject.org
---
arch/x86/xen/smp.c | 4 ----
arch/x86/xen/smp_pv.c | 2 --
2 files changed, 6 deletions(-)
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -268,20 +268,16 @@ void xen_send_IPI_allbutself(int vector)
static irqreturn_t xen_call_function_interrupt(int irq, void *dev_id)
{
- irq_enter();
generic_smp_call_function_interrupt();
inc_irq_stat(irq_call_count);
- irq_exit();
return IRQ_HANDLED;
}
static irqreturn_t xen_call_function_single_interrupt(int irq, void *dev_id)
{
- irq_enter();
generic_smp_call_function_single_interrupt();
inc_irq_stat(irq_call_count);
- irq_exit();
return IRQ_HANDLED;
}
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -458,10 +458,8 @@ static void xen_pv_stop_other_cpus(int w
static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id)
{
- irq_enter();
irq_work_run();
inc_irq_stat(apic_irq_work_irqs);
- irq_exit();
return IRQ_HANDLED;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations
2021-10-12 13:33 [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations, Thomas Gleixner
@ 2021-10-12 14:25 ` Juergen Gross
2021-10-27 13:19 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2021-10-12 14:25 UTC (permalink / raw)
To: Thomas Gleixner, LKML; +Cc: x86, Stefano Stabellini, Boris Ostrovsky, xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 510 bytes --]
On 12.10.21 15:33, Thomas Gleixner wrote:
> All these handlers are regular device interrupt handlers, so they already
> went through the proper entry code which handles this correctly.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: x86@kernel.org
> Cc: xen-devel@lists.xenproject.org
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations
2021-10-12 14:25 ` [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations Juergen Gross
@ 2021-10-27 13:19 ` Boris Ostrovsky
0 siblings, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2021-10-27 13:19 UTC (permalink / raw)
To: Juergen Gross, Thomas Gleixner, LKML; +Cc: x86, Stefano Stabellini, xen-devel
On 10/12/21 10:25 AM, Juergen Gross wrote:
> On 12.10.21 15:33, Thomas Gleixner wrote:
>> All these handlers are regular device interrupt handlers, so they already
>> went through the proper entry code which handles this correctly.
>>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Juergen Gross <jgross@suse.com>
>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: x86@kernel.org
>> Cc: xen-devel@lists.xenproject.org
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
Applied to for-linus-5.16
-boris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-27 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-12 13:33 [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations, Thomas Gleixner
2021-10-12 14:25 ` [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations Juergen Gross
2021-10-27 13:19 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox