From: Thomas Gleixner <tglx@linutronix.de>
To: Kees Cook <keescook@chromium.org>, Yejune Deng <yejune.deng@gmail.com>
Cc: peterz@infradead.org, frederic@kernel.org, mingo@kernel.org,
dave@stgolabs.net, linux-kernel@vger.kernel.org,
Yejune Deng <yejunedeng@gmail.com>
Subject: Re: [PATCH] softirq: Remove the unnecessary CONFIG_TRACE_IRQFLAGS
Date: Tue, 10 Aug 2021 15:59:10 +0200 [thread overview]
Message-ID: <877dgts8nl.ffs@tglx> (raw)
In-Reply-To: <202106021051.0AF942F9@keescook>
On Wed, Jun 02 2021 at 10:53, Kees Cook wrote:
> On Wed, Jun 02, 2021 at 03:34:42PM +0800, Yejune Deng wrote:
>> The local_irq_enable() and local_irq_disable() had two definitions that
>> include CONFIG_TRACE_IRQFLAGS or not.
>
> Hm, this has a behavioral change. Current code only does tracing and
> raw_local_irq_disable/enable when CONFIG_TRACE_IRQFLAGS. This change
> causes it to always do raw_local_irq_disable/enable. Which is the right
> behavior?
Disabling interrupts is only required when CONFIG_TRACE_IRQFLAGS=y. So
the code is correct as is.
Thanks,
tglx
prev parent reply other threads:[~2021-08-10 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 7:34 [PATCH] softirq: Remove the unnecessary CONFIG_TRACE_IRQFLAGS Yejune Deng
2021-06-02 17:53 ` Kees Cook
2021-08-10 13:59 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dgts8nl.ffs@tglx \
--to=tglx@linutronix.de \
--cc=dave@stgolabs.net \
--cc=frederic@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=yejune.deng@gmail.com \
--cc=yejunedeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox