From: Michael Ellerman <mpe@ellerman.id.au>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] of: drop a reference on error in __of_attach_node_sysfs()
Date: Wed, 20 May 2020 20:06:39 +1000 [thread overview]
Message-ID: <877dx69az4.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200518113021.GB48709@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> writes:
> We add a new of_node_get() to this function, but we should drop the
> reference if kobject_add().
^
fails?
>
> Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in __of_attach_node_sysfs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> From static analysis. Maybe we should just call of_node_get() right
> before we return 0?
Yeah that would be simpler and equally correct AFAICS.
cheers
> diff --git a/drivers/of/kobj.c b/drivers/of/kobj.c
> index c72eef988041..a90dc4b3b060 100644
> --- a/drivers/of/kobj.c
> +++ b/drivers/of/kobj.c
> @@ -138,8 +138,10 @@ int __of_attach_node_sysfs(struct device_node *np)
>
> rc = kobject_add(&np->kobj, parent, "%s", name);
> kfree(name);
> - if (rc)
> + if (rc) {
> + of_node_put(np);
> return rc;
> + }
>
> for_each_property_of_node(np, pp)
> __of_add_property_sysfs(np, pp);
> --
> 2.26.2
next prev parent reply other threads:[~2020-05-20 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 11:30 [PATCH] of: drop a reference on error in __of_attach_node_sysfs() Dan Carpenter
2020-05-20 10:06 ` Michael Ellerman [this message]
2020-05-20 12:04 ` [PATCH v2] of: Fix a refcounting bug " Dan Carpenter
2020-05-27 18:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dx69az4.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox