From: Thomas Gleixner <tglx@linutronix.de>
To: Changbin Du <changbin.du@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
hpa@zytor.com, x86@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Changbin Du <changbin.du@gmail.com>
Subject: Re: [PATCH] x86/nmi: remove the irqwork from long duration nmi handler
Date: Thu, 09 Jan 2020 21:55:51 +0100 [thread overview]
Message-ID: <877e20bb8o.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200101072017.82990-1-changbin.du@gmail.com>
Changbin Du <changbin.du@gmail.com> writes:
> First, printk is NMI context safe now since the safe printk has been
> implemented. The safe printk already has an irqwork to make NMI context
> safe.
>
> Second, the NMI irqwork actually does not work if a NMI handler causes
> panic by watchdog timeout. This NMI irqwork have no chance to run in such
> case, while the safe printk will flush its per-cpu buffer before panic.
>
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
Looks about right.
Acked-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2020-01-09 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 7:20 [PATCH] x86/nmi: remove the irqwork from long duration nmi handler Changbin Du
2020-01-07 14:41 ` Changbin Du
2020-01-09 20:55 ` Thomas Gleixner [this message]
2020-01-09 21:02 ` Borislav Petkov
[not found] ` <20200110140549.xqjhrdpxllkvqbuk@mail.google.com>
[not found] ` <20200110151329.GF19453@zn.tnic>
2020-01-10 17:34 ` Changbin Du
2020-01-10 19:58 ` Borislav Petkov
2020-01-11 0:17 ` Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e20bb8o.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=changbin.du@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox