From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1040AC32750 for ; Tue, 13 Aug 2019 08:50:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E060E206C2 for ; Tue, 13 Aug 2019 08:50:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727510AbfHMIua (ORCPT ); Tue, 13 Aug 2019 04:50:30 -0400 Received: from mail03.asahi-net.or.jp ([202.224.55.15]:44746 "EHLO mail03.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726935AbfHMIua (ORCPT ); Tue, 13 Aug 2019 04:50:30 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id 35B4F56351; Tue, 13 Aug 2019 17:50:29 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 4887D240085; Tue, 13 Aug 2019 17:50:28 +0900 (JST) Date: Tue, 13 Aug 2019 17:50:27 +0900 Message-ID: <877e7hphyk.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: "Gustavo A. R. Silva" Cc: Rich Felker , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Joe Perches Subject: Re: [PATCH v2] sh: kernel: disassemble: Mark expected switch fall-throughs In-Reply-To: <20190810052442.GA21354@embeddedor> References: <20190810052442.GA21354@embeddedor> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Aug 2019 14:24:42 +0900, Gustavo A. R. Silva wrote: > > Remove logically dead code and mark switch cases where we are expecting > to fall through. > > Fix the following warnings (Building: defconfig sh): > > arch/sh/kernel/disassemble.c:478:8: warning: this statement may fall > through [-Wimplicit-fallthrough=] > arch/sh/kernel/disassemble.c:487:8: warning: this statement may fall > through [-Wimplicit-fallthrough=] > arch/sh/kernel/disassemble.c:496:8: warning: this statement may fall > through [-Wimplicit-fallthrough=] > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > - Remove logically dead code. Pointed out by Joe Perches. > > NOTE: If no one cares, I'll apply this to my tree and queue it up > for 5.3-rc4. > > arch/sh/kernel/disassemble.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/sh/kernel/disassemble.c b/arch/sh/kernel/disassemble.c > index defebf1a9c8a..845543780cc5 100644 > --- a/arch/sh/kernel/disassemble.c > +++ b/arch/sh/kernel/disassemble.c > @@ -475,8 +475,6 @@ static void print_sh_insn(u32 memaddr, u16 insn) > printk("dbr"); > break; > case FD_REG_N: > - if (0) > - goto d_reg_n; > case F_REG_N: > printk("fr%d", rn); > break; > @@ -488,7 +486,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) > printk("xd%d", rn & ~1); > break; > } > - d_reg_n: > + /* else, fall through */ > case D_REG_N: > printk("dr%d", rn); > break; > @@ -497,6 +495,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) > printk("xd%d", rm & ~1); > break; > } > + /* else, fall through */ > case D_REG_M: > printk("dr%d", rm); > break; > -- > 2.22.0 > Applied sh-next. Thanks. -- Yosinori Sato