From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 971F5C43381 for ; Tue, 19 Feb 2019 15:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F4E6206DD for ; Tue, 19 Feb 2019 15:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728946AbfBSPD5 convert rfc822-to-8bit (ORCPT ); Tue, 19 Feb 2019 10:03:57 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:39815 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbfBSPD4 (ORCPT ); Tue, 19 Feb 2019 10:03:56 -0500 Received: from localhost (alyon-652-1-306-203.w90-53.abo.wanadoo.fr [90.53.137.203]) (Authenticated sender: gregory.clement@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id D966E240008; Tue, 19 Feb 2019 15:03:51 +0000 (UTC) From: Gregory CLEMENT To: Chris Packham , andrew@lunn.ch, jason@lakedaemon.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chris Packham , Sebastian Hesselbarth , Russell King Subject: Re: [PATCH] ARM: mvebu: kirkwood: remove error message when retrieving mac address In-Reply-To: <20190218024645.29059-1-chris.packham@alliedtelesis.co.nz> References: <20190218024645.29059-1-chris.packham@alliedtelesis.co.nz> Date: Tue, 19 Feb 2019 16:03:51 +0100 Message-ID: <877edv3jmw.fsf@FE-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, On lun., févr. 18 2019, Chris Packham wrote: > Kirkwood has always had the ability to retrieve the local-mac-address > from the hardware (usually this was configured by the bootloader). This > is particularly useful when dealing with a legacy non-DT aware > bootloader. > > The "error" message just indicated that the board used an old bootloader > and in many cases users can't do anything about this. The message > probably should have been pr_info() to inform the user that the kernel > has been helpful but rather than than let's remove it entirely to make > the kernel less noisy. > > Signed-off-by: Chris Packham I'm OK with this patch, however as it is not a fix, it's too late for 5.1. I will apply it on mvebu/arm for 5.2 once 5.1-rc1 will be released. Thanks, gregory > --- > arch/arm/mach-mvebu/kirkwood.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c > index 0aa88105d46e..bf3ff0f580c2 100644 > --- a/arch/arm/mach-mvebu/kirkwood.c > +++ b/arch/arm/mach-mvebu/kirkwood.c > @@ -107,8 +107,6 @@ static void __init kirkwood_dt_eth_fixup(void) > clk_prepare_enable(clk); > > /* store MAC address register contents in local-mac-address */ > - pr_err(FW_INFO "%pOF: local-mac-address is not set\n", np); > - > pmac = kzalloc(sizeof(*pmac) + 6, GFP_KERNEL); > if (!pmac) > goto eth_fixup_no_mem; > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com