Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

Huang, Ying
2018-07-10T01:19:45Z

Dave Hansen <dave.hansen@linux.intel.com> writes:

>> config THP_SWAP
>> def_bool y
>> - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP
>> + depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP
>> help
>
>
> This seems like a bug-fix. Is there a reason this didn't cause problems
> up to now?

Yes. The original code has some problem in theory, but not in practice
because all code enclosed by

#ifdef CONFIG_THP_SWAP
#endif

are in swapfile.c. But that will be not true in this patchset.

Best Regards,
Huang, Ying