From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932284AbeCKMl6 (ORCPT ); Sun, 11 Mar 2018 08:41:58 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:43313 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932126AbeCKMl4 (ORCPT ); Sun, 11 Mar 2018 08:41:56 -0400 X-Google-Smtp-Source: AG47ELt6IN7UFy5UKlZz8Wy8NDShpMev/dqREoiMi1POB9PyTuPoTupPJXaeS46gTlCBXj0brmhd1Q== From: Roman Lakeev Cc: Roman Lakeev Cc: Christoph Lameter Cc: Pekka Enberg Cc: David Rientjes Cc: Joonsoo Kim Cc: Andrew Morton Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] mm/slab.c: remove duplicated check of colour_next In-Reply-To: <87bmfulry9.fsf@gmail.com> Date: Sun, 11 Mar 2018 11:05:29 +0300 Message-ID: <877eqilr71.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry for strange message in previous mail. remove check that offset greater than cachep->colour bacause this is already checked in previous lines Signed-off-by: Roman Lakeev --- mm/slab.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index 324446621b3e..6a48f122bd82 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -2674,11 +2674,7 @@ static struct page *cache_grow_begin(struct kmem_cache *cachep, if (n->colour_next >= cachep->colour) n->colour_next = 0; - offset = n->colour_next; - if (offset >= cachep->colour) - offset = 0; - - offset *= cachep->colour_off; + offset = n->colour_next * cachep->colour_off; /* Get slab management. */ freelist = alloc_slabmgmt(cachep, page, offset, -- 2.16.2