From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750953AbdK3FVi (ORCPT ); Thu, 30 Nov 2017 00:21:38 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:41723 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbdK3FVg (ORCPT ); Thu, 30 Nov 2017 00:21:36 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Ian Kent Cc: Linux Containers , linux-kernel@vger.kernel.org, Miklos Szeredi , linux-fsdevel@vger.kernel.org, Seth Forshee References: <874lpck52r.fsf@xmission.com> Date: Wed, 29 Nov 2017 23:21:24 -0600 In-Reply-To: (Ian Kent's message of "Thu, 30 Nov 2017 08:11:55 +0800") Message-ID: <877eu8ibor.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1eKHHt-0005Aw-MG;;;mid=<877eu8ibor.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=67.3.248.7;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+cRnKXW30cVhHfuXcpZ4Vt8y7PMhp7+zU= X-SA-Exim-Connect-IP: 67.3.248.7 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4560] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Ian Kent X-Spam-Relay-Country: X-Spam-Timing: total 5103 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 3.0 (0.1%), b_tie_ro: 2.1 (0.0%), parse: 0.96 (0.0%), extract_message_metadata: 11 (0.2%), get_uri_detail_list: 1.14 (0.0%), tests_pri_-1000: 3.7 (0.1%), tests_pri_-950: 1.12 (0.0%), tests_pri_-900: 0.96 (0.0%), tests_pri_-400: 16 (0.3%), check_bayes: 15 (0.3%), b_tokenize: 4.5 (0.1%), b_tok_get_all: 5 (0.1%), b_comp_prob: 1.61 (0.0%), b_tok_touch_all: 2.2 (0.0%), b_finish: 0.62 (0.0%), tests_pri_0: 111 (2.2%), check_dkim_signature: 0.45 (0.0%), check_dkim_adsp: 2.6 (0.1%), tests_pri_500: 4953 (97.1%), poll_dns_idle: 4948 (97.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 0/2] userns: automount cleanups X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ian Kent writes: > On 30/11/17 08:01, Eric W. Biederman wrote: >> >> While reviewing some code I realized that in getting d_automount working >> with s_user_ns I had left behind some unnecessary relics of the blind >> path I started down. Here are two patches that remove those relics. >> >> Unless someone has another preference I will drop them in my userns tree >> and merge them that way. > > I saw the "->s_user_ns != &init_user_ns" and wondered if that would > trigger for automount(8) run entirely with a container (eg. docker)? autofs still needs FS_USERNS_MOUNT before you can reach that point. But docker does have a mode ?--userns-remap? where it sets up the containers mounts that way. I think in principle that should work and be safe. I don't know how robust autofs is against malicious users. Which is the question to ask before actually adding FS_USERNS_MOUNT in struct file_system_type. > Anyway, it's gone now, so ACK to these two, thanks Eric. Eric