From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752341AbdJ3IQY (ORCPT ); Mon, 30 Oct 2017 04:16:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48068 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751978AbdJ3IQX (ORCPT ); Mon, 30 Oct 2017 04:16:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1358B6A7D4 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vkuznets@redhat.com From: Vitaly Kuznetsov To: Greg KH Cc: kys@microsoft.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, leann.ogasawara@canonical.com, marcelo.cerri@canonical.com, sthemmin@microsoft.com Subject: Re: [PATCH 10/17] hyper-v: trace vmbus_open() References: <20171029192030.12356-1-kys@exchange.microsoft.com> <20171029192116.12466-1-kys@exchange.microsoft.com> <20171029192116.12466-10-kys@exchange.microsoft.com> <20171029205958.GA30187@kroah.com> Date: Mon, 30 Oct 2017 09:16:19 +0100 In-Reply-To: <20171029205958.GA30187@kroah.com> (Greg KH's message of "Sun, 29 Oct 2017 21:59:58 +0100") Message-ID: <877evdyrsc.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 30 Oct 2017 08:16:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH writes: > On Sun, Oct 29, 2017 at 12:21:09PM -0700, kys@exchange.microsoft.com wrote: >> From: Vitaly Kuznetsov >> >> Add tracepoint to CHANNELMSG_OPENCHANNEL sender. >> >> Signed-off-by: Vitaly Kuznetsov >> Signed-off-by: K. Y. Srinivasan >> --- >> drivers/hv/channel.c | 2 ++ >> drivers/hv/hv_trace.h | 27 +++++++++++++++++++++++++++ >> 2 files changed, 29 insertions(+) >> >> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c >> index a406beb10dd0..739b3fe1e0fb 100644 >> --- a/drivers/hv/channel.c >> +++ b/drivers/hv/channel.c >> @@ -185,6 +185,8 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size, >> ret = vmbus_post_msg(open_msg, >> sizeof(struct vmbus_channel_open_channel), true); >> >> + trace_vmbus_open(open_msg, ret); > > Why add tracepoints for things that ftrace can handle automatically? This series adds pretty prints for structures printing what is needed and in the right format significantly simplifying debugging. And it wouldn't make sense to add tracepoints to *some* messages-related functions and skip others where parsing is more trivial. -- Vitaly