From: "Bjørn Mork" <bjorn@mork.no>
To: Douglas Anderson <dianders@chromium.org>
Cc: Oliver Neukum <oneukum@suse.com>,
groeck@chromium.org, grundler@chromium.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] usbnet: Fix memory leak when rx_submit() fails
Date: Tue, 19 Sep 2017 19:41:09 +0200 [thread overview]
Message-ID: <877ewuoabu.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20170919161522.995-3-dianders@chromium.org> (Douglas Anderson's message of "Tue, 19 Sep 2017 09:15:22 -0700")
Douglas Anderson <dianders@chromium.org> writes:
> If rx_submit() returns an error code then nobody calls usb_free_urb().
> That means it's leaked.
Nope. rx_submit() will call usb_free_urb() before returning an error:
static int rx_submit (struct usbnet *dev, struct urb *urb, gfp_t flags)
..
if (!skb) {
netif_dbg(dev, rx_err, dev->net, "no rx skb\n");
usbnet_defer_kevent (dev, EVENT_RX_MEMORY);
usb_free_urb (urb);
return -ENOMEM;
}
..
if (retval) {
dev_kfree_skb_any (skb);
usb_free_urb (urb);
}
Bjørn
next prev parent reply other threads:[~2017-09-19 17:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 16:15 [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped" Douglas Anderson
2017-09-19 16:15 ` [RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent() Douglas Anderson
2017-09-19 20:37 ` Oliver Neukum
2017-09-19 20:51 ` Guenter Roeck
2017-09-20 8:23 ` Oliver Neukum
2017-09-19 20:53 ` Doug Anderson
2017-09-20 8:25 ` Oliver Neukum
2017-09-19 16:15 ` [RFC PATCH 3/3] usbnet: Fix memory leak when rx_submit() fails Douglas Anderson
2017-09-19 17:41 ` Bjørn Mork [this message]
2017-09-19 16:43 ` [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped" Guenter Roeck
2017-09-19 17:45 ` Bjørn Mork
2017-09-19 20:36 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ewuoabu.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=grundler@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox